Comments (8)
Taking this
from derek.
Thank you for logging this
from derek.
Still a fan of this feature
from derek.
Derek add label: priority/low
from derek.
The idea is here that:
PRs should only be raised to target master - therefore if someone raises a PR that doesn't - apply a label.
I.e.
I raise a PR to a branch named 0.7.0 - that should add a label, I don't know what label but am open to suggestions: attention/target-branch
.
2nd scenario:
Someone raises a PR from the master branch of their repo. This can be destructive to merge - especially if that person has been rebasing commits / force pushing or even altering historic commits.
Derek should add a warning comment:
It appears that you are submitting changes directly from your master branch, we encourage you to raise a new pull request from a named branch i.e.
git checkout -b my_feature
.
It should also add a label like: attention/source-branch
In both scenarios the user can only raise a new PR to fix the problem. This means no code is needed to remove the labels.
from derek.
So adding a label rather than closing the PR? Would this be a separate 'feature' that could be enabled / disabled in the config yaml? Would these 2 scenarios (target and origin) be separate features? Or part of a single 'branch check' feature?
from derek.
This would be worth doing - even at a simplistic level - no PRs from master for instance.
from derek.
I met with Ivana and Dimitar. We think the action should be:
- Close the PR (because you can't recover without creating a new PR from a different branch)
- Give a comment - should say a git command to help them such as
git checkout -b my_feature
and raise a PR from there - Ivana liked the idea of the label - let's use the prefix of "review/" to match the listing in #43
from derek.
Related Issues (20)
- Pull Derek's watchdog binary via multi-stage build HOT 1
- Run Derek container as non-root user HOT 4
- Publishing Docker images is broken HOT 4
- Have Derek add commits as well as PRs closed in each release note HOT 1
- Add 1 min safety window for commit listing HOT 2
- Derek marks PR with `no-dco` but the commit is signed HOT 1
- Proposal: Label and message for PRs with Merge Commits HOT 2
- Add Derek to two new organizations (vielmetti, tinkerbell) HOT 3
- Feature request: give multiple commands within a single comment HOT 2
- [Bug] Regression in authentication code HOT 4
- Inconsistent fetching of commits HOT 4
- Switch to using go modules HOT 3
- Proposal: Detect Hacktoberfest PRs without requiring commit sign-off HOT 7
- Suggestion: make this project more visible HOT 3
- Crash generating release notes HOT 1
- Detect repository default branch HOT 4
- Migrate to GitHub Actions HOT 3
- Have Derek show a link for changes between releases on auto-generated release notes. HOT 3
- Validate HMAC with SHA256
- Exclude pre-releases from release notes HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from derek.