Comments (15)
I'm saying that I don't know much about it, I didn't write this code or actually used it myself ;) Others like @tejashah88 or @mreinstein will know a lot more!
from alexa-app-server.
Whcih version are you using? I believe this has been fixed, try the released 2.3.1 and if that doesn't work HEAD.
from alexa-app-server.
yea I'm on 2.3.1
Is there an easy way to use head within my node app? Or do I need to checkout the git repo and move the content into the npm_modules dir?
from alexa-app-server.
You should be able to do this in package.json:
"dependencies": {
"alexa-app-server": "alexa-js/alexa-app-server"
}
See https://docs.npmjs.com/files/package.json#github-urls for details.
Can you please verify that this is actually fixed? We can close the issue then.
We'll release the next version shortly (see #47), after #48 is resolved.
from alexa-app-server.
Changed my dependencies per your suggestion in the package.json file and restarted my app. Getting the same error.
from alexa-app-server.
What's in alexa-app-server/index.js:97
? You can see on master that https://github.com/alexa-js/alexa-app-server/blob/master/index.js#L97 is not at all able to throw that error.
from alexa-app-server.
you are right... I forgot to run an npm install before restarting. okay, after doing that it doesn't throw the er error I was seeing before. However, it also isn't throwing a 500 error when I try from postman and not an echo device. I get a valid response:
{
"version": "1.0",
"response": {
"directives": [],
"shouldEndSession": true,
"card": {
"type": "LinkAccount"
},
"outputSpeech": {
"type": "SSML",
"ssml": "<speak>Looks like you need to link your account. Please open the Alexa app for setup.</speak>"
}
},
"sessionAttributes": {}
}
I thought with verify set to true that it would've thrown an error, correct?
from alexa-app-server.
I am not sure what this error is or what to do with it ...
from alexa-app-server.
It's not an error. That's the point. If a request comes in from a non-echo, my assumption is the alexa-verifier code should mark it as an error. and there is no error.
from alexa-app-server.
Possibly, I don't know much about this. I would read the code and docs wrt what it's supposed to do, maybe open an issue in alexa-verifier?
from alexa-app-server.
So, just to make sure I'm following you, are you saying that the flag "verify" in the alexa-app-server documentation:
// This will add verification for alexa requests as require by the alexa certification
// process. Provied by alexa-verifier
verify: false,
hasn't been tested? And I should use the alexa-verifier module directly?
from alexa-app-server.
I've never used alexa-app-server
, so I can't claim to be any sort of expert on that. One thing I did notice in looking at the code:
https://github.com/alexa-js/alexa-app-server/blob/master/index.js#L85
this is not forcing the requests to pass the header check. It should instead probably be:
self.express.use(endpoint, alexaVerifierMiddleware({ strictHeaderCheck: true ));
^ this is assuming only Alexa requests will flow through this express instance.
from alexa-app-server.
@tejashah88 I need your input on something. The PR I just sent enforces strict header checking and all of the verification logic that amazon requires when submitting a skill to run on production. I've noticed these tests:
https://github.com/alexa-js/alexa-app-server/blob/master/test/test-examples-server-verification.js
2 of them expect a 200 code back. I think these should actually be 401 errors.
I'd appreciate your thoughts since it seems you actually wrote the tests.
from alexa-app-server.
@mreinstein You're right! They should be expecting 401 errors.
I guess the only thing that seems to nag me is that we don't have a way to actually test if a 200 code is being sent back when using an actual Alexa device, since we are basically assuming that it should work anyways. Unless Amazon gave a way to test this with a virtual Amazon device or something, I guess one would have to have some sort of test skill that would verify that the verification is working as expected.
from alexa-app-server.
Closed via #51, thanks @mreinstein.
from alexa-app-server.
Related Issues (20)
- Cannot start server HOT 2
- Getting different response in alexa developer service simulator and in alexa app server testing utility HOT 7
- Use template-literal instead of EJS
- Asynchronous Functions not working HOT 7
- How to show the current playing item (songs) in player or queue screen in alexa app.
- Syntax generation for new Skill Builder interface HOT 2
- Receiving Interaction Model JSON in new Dev Console HOT 2
- The raw request body has already been parsed error message is displaying in alexa-app-server
- Is this repository still being actively maintained? HOT 3
- Add Snyk to alexa-app-server
- Release v. Next HOT 2
- Node 7.10.0 and 7.10.1 fail custom binding tests HOT 6
- Add new node versions for CI HOT 1
- {"status":"failure","reason":"missing certificate url"} HOT 4
- account linking with alexa-app-server HOT 2
- Create dynamic apps
- how to start alexa-app-server on hosting server ? HOT 3
- J
- K
- Access
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alexa-app-server.