Templates in test.ejs do not include context property. userId is extracted from this... about alexa-app-server

[bwmcin]

Just for context, I was "following" the directions on the tutorial and found that the persistence didn't work. In debugging the problem, I discovered that the template for the intents was in test.ejs. I would suggest that since the tutorial "requires" this file, that in one sense, this isn't a "test" file, nor is it a "debugging" file. Did I miss the instructions somewhere that one needs to modify this file before using the persistence mechanism? I would believe you test scenario should process all intents that are to be experienced by the folks learning the system. Thank you.

[dblock]

What's this persistence tutorial? :)

[tejashah88]

I believe this is because #22 was not merged yet.

[dblock]

Aha. Could we finish #22 with some tests pls?

[bwmcin]

Yes, it was. And I was also playing with the chip tutorial. I believe the persistence tutorial also has another error in the refactoring—I will had to do some more exploring on that. Regards, Bruce From: Daniel Doubrovkine (dB.) @dblockdotorg [mailto:[email protected]] Sent: Tuesday, January 24, 2017 12:31 PM To: alexa-js/alexa-app-server <[email protected]> Cc: bwmcin <[email protected]>; Author <[email protected]> Subject: Re: [alexa-js/alexa-app-server] Templates in test.ejs do not include context property. userId is extracted from this... (#42) What's this persistence tutorial? :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#42 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ALbsU6HGs27-sskdOvAReYyQ4umNEfTEks5rVl-KgaJpZM4LsvFc> . <https://github.com/notifications/beacon/ALbsU7UlWXQM9kVTgqA_OX9DA8pIAJu8ks5rVl-KgaJpZM4LsvFc.gif>

…

_____ No virus found in this message. Checked by AVG - www.avg.com <http://www.avg.com/email-signature> Version: 2016.0.7998 / Virus Database: 4749/13827 - Release Date: 01/24/17

[tejashah88]

@dblock By tests, you mean for mocha or actually testing it, since I didn't necessarily find any mocha tests for this?

[dblock]

Yes. We're changing some code, we want tests that otherwise would break. New management new rules, no more untested code ;)

[tejashah88]

I understand that we need testing, but any specifics for how to do so? (ie. mocha testing or manually testing?)

[dblock]

Mocha of course.

[tejashah88]

After trying for a couple of days, there doesn't seem to be an easy solution to test this without some breaking changes to the debugger. IMO, if the alexa-app and alexa-app-server core code are tested well enough, there shouldn't need to be testing the debugger, at least with mocha. Currently, I'm re-factoring the test.ejs file, as it's pretty much a big mess to maintain right now. Until we have a way of testing the debugger otherwise, I'd say we leave it alone otherwise.

[dblock]

I only disagree "in principle", any code we ship that users can use should have automated tests because otherwise we break it every time we make a change or new contributors are scared of contributing.

[dblock]

I merged #22, we can pay our technical debts later.