Support Inline If about blanket

[alex-seville]

I guess it depends how complex we do it. I think handling single line if's is the priority for now, and this could be an advanced thing later.

single line if:

if (blah)
   action;
 else
   otheraction;

[alex-seville]

Maybe we can somehow use the parser built into jshint, or copy the code:
https://github.com/jshint/jshint/tree/master/src/next

[alex-seville]

Or better yet, use the parsing of Uglify.js:
https://github.com/mishoo/UglifyJS

[dervalp]

:) +1

On Tue, Oct 16, 2012 at 4:28 PM, Alex Seville [email protected]:

Or better yet, use the parsing of Uglify.js:
https://github.com/mishoo/UglifyJS

—
Reply to this email directly or view it on GitHubhttps://github.com/Migrii/blanket/issues/16#issuecomment-9491809.

[alex-seville]

These might be of some help:
https://github.com/mishoo/UglifyJS/blob/master/tmp/instrument.js
http://tobyho.com/2012/01/04/fun-with-asts-and-uglify/

[alex-seville]

Okay, I put some test cases into that instrument.js file and got the following results:

// EDGE CASE 1, no bracket for *FAILS* 
        for (var i = 0; i < 5; ++i)
                console.log("foo2");

        // EDGE case 2, no bracket if *FAILS*
        if (true)
            console.log("foo3")

        //EDGE case 3, mis matching the brackets *WORKS*
        if (false){
            console.log("dujh");
        }
        else
        {
            console.log("foo3");
        }

        //EDGE case 4, multi line logical statement *WORKS*
        var out = false ||
            true;
        console.log(out);

        //EDGE case 5, multi line arithmetic *WORKS*
        var lastcase = 12+
                        12+
                        6;
        console.log(lastcase);

So clearly this is a good tool to use. It will help with the parsing of js, except in a few cases. I'll work on getting the "no bracket if/for" issue working, and after that I'll integrate it into the lib/blanket.js file and write some tests.

[alex-seville]

Here are the results of above:

trace("for", 27, 8, 28, 35);
    //FAIL
    for (var i = 0; i < 5; ++i) trace("stat", 28, 16, 28, 35);
    console.log("foo2");
    //FAILEND

    trace("if", 31, 8, 32, 30);

    //FAIL
    if (true) trace("stat", 32, 12, 32, 30);
    console.log("foo3");
    //FAILEND

    trace("if", 35, 8, 41, 8);
    if (false) {
        trace("stat", 36, 12, 36, 31);
        console.log("dujh");
    } else {
        trace("stat", 40, 12, 40, 31);
        console.log("foo3");
    }
    trace("var", 44, 8, 45, 16);
    var out = false || true;
    trace("stat", 46, 8, 46, 24);
    console.log(out);
    trace("var", 49, 8, 51, 25);
    var lastcase = 12 + 12 + 6;
    trace("stat", 52, 8, 52, 29);
    console.log(lastcase);

I've added some extra spacing to clearly show the failing cases.

[alex-seville]

I figured out how to detect if it's an IF (or try, or while, etc...) without brackets, but I don't know how to update the parse tree.

Line 61: https://gist.github.com/3900493

is where this needs to be handled.

[alex-seville]

Nice, I think I got a parser working:
https://gist.github.com/3909508

I threw the ultimate one liner at it, and with a small modification it generates good instrumented code. Now I just need to integrate it into the solution and write tests.

[alex-seville]

I think I've resolved all these issues now.