Comments (9)
I think unfortunately(/hopefully) this issue and #114 have already been resolved, but npm hasn't been updated.
You could test this theory by copying lib/blanket.js
from github to your node_modules/blanket/lib
folder.
I feel like this issue may already be resolved because on the browser side it is no longer counting comments. You can see this in action with test/requirejs/require_runner.html
. The first line of the covered file is a comment.
I will try to update npm asap. Thanks.
from blanket.
npm updated to 0.9.8. Can you let me know if you still experience the same problem? Thanks.
from blanket.
Thanks for the quick update, this problem however still seems to exist on node. The output SLOC/line hit counts dont seem to have changed after upgrading
from blanket.
Can you provide a sample file? If it's proprietary you can change some of the non-comment lines. There may be some other code in the file that combines with the comment to cause a problem. I've run some tests here of just single line comments and I get the same result in node and in the browser, so I'm thinking that your inconsistency might be the symptom of a more complex bug.
from blanket.
Here is a toy code example module that seems to reproduce the problem for me:
module.exports = {
// A comment
d: function (data) {
this.stuff(data);
}
};
a test file requires blanket and the above module,
require('blanket')('testblanket');
require('./test');
and then mocha is run with: mocha --reporter html-cov test.js > test.html
output:
1
2 1 module.exports = {
3
4 1 // A comment
5 d: function (data) {
6 0 this.stuff(data);
7 }
8 };
[email protected] reported by npm
from blanket.
Great, thanks for the sample. I'll take a look at this tomorrow and see where the issue is.
from blanket.
I wrote a test and solved this problem. Thanks for highlighting it. I will commit it in a day or two, I accidentally added it in the middle of another commit, so I'll finish the other features and push it in.
from blanket.
Fixed in #117
from blanket.
Excellent will test today, thanks again!
from blanket.
Related Issues (20)
- Commented on: Not seeing any reports - noob alert #244 HOT 1
- _$jscoverage is not defined | blanket 1.2.1 HOT 21
- Reason for replacing ".js" with ""
- In ploymer,the script is written in the component html,is there any method to set data-cover on the script HOT 2
- Publish the latest version HOT 1
- Global object replaced on QUnit test
- How to use Blanket.js in test files loaded with Require.js? HOT 2
- blanket js does not given correct results.
- Can blanket handle source maps?
- documention is wrong for using with mocha HOT 1
- Advice on how to use with WebDriver. HOT 1
- Support for phantomjs 2.1.1 (for blanket to work on ppc64le architecture)
- Coverage for hoisted vars HOT 2
- I am getting Error: invalid reporter "html-cov" HOT 1
- Tests stop running on upgrading to [email protected] HOT 1
- make a new release on the github?
- Instrumentation affects test results.
- Running Jasmine Code Coverage using command Line
- Deprecate this?
- Hi
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blanket.