Coder Social home page Coder Social logo

Comments (11)

alex-hhh avatar alex-hhh commented on August 28, 2024 2

Just a followup on this, I'm currently discussing this with the Emacs and SQL mode maintainers.

They are interested in the package and we are working out some details on what the best way is to add this to Emacs.

from emacs-sql-indent.

alex-hhh avatar alex-hhh commented on August 28, 2024 1

I tried this a while ago, but the task got lost, see

https://lists.gnu.org/archive/html/emacs-devel/2015-12/msg00943.html

I will try again, to see how it goes...

from emacs-sql-indent.

phil-s avatar phil-s commented on August 28, 2024

Many thanks for following that up.

from emacs-sql-indent.

PierreTechoueyres avatar PierreTechoueyres commented on August 28, 2024

Note that there already is an "sql-indent" package on melpa (https://github.com/bsvingen/sql-indent).
If you want to keep the sqlind prefix, you'll probably have to rename the el files with this prefix.
Another solution is to provide and emacs-sql-indent-pkg.el like the one attached.

emacs-sql-indent-pkg.el.txt

from emacs-sql-indent.

PierreTechoueyres avatar PierreTechoueyres commented on August 28, 2024

Sorry, the solution with emacs-sql-indent-pkg.el doesn't seem to work.

from emacs-sql-indent.

phil-s avatar phil-s commented on August 28, 2024

sql-indent.el and a sql-indent symbol prefix seems nicest to me, FWIW.

That library on MELPA seems to have been written by Alex Schroeder (who runs the Emacs Wiki), and at < 200 lines including comments, it's a relatively small library. I would hazard a guess that Alex might be entirely happy to deprecate his library in favour of a more sophisticated replacement, so the naming conflict may be a non-issue.

from emacs-sql-indent.

alex-hhh avatar alex-hhh commented on August 28, 2024

Even if I rename the package to something else, the two packages are still not compatible, since both of them will install their own indent-line-function for sql-mode. This package defines the sqlind-minor-mode to enable the syntactic indentation, so it is possible to have this package installed, but not active. The other sql-indent package, however, will hook itself into the indentation mechanism as soon as it is loaded, so it is not possible to have that package installed but not active.

If both packages are installed at the same time, there would cause unexpected and confusing behavior for the user. Users can only install one or the other, regardless of how the packages are named.

from emacs-sql-indent.

alex-hhh avatar alex-hhh commented on August 28, 2024

I tried to raise this on the emacs-devel mailing list one last time, see

https://lists.gnu.org/archive/html/emacs-devel/2017-08/msg00142.html

Michael Mauger, who maintains sql.el in the GNU Emacs source, has responded to my email as well.. Regrettably, he chose to email me in private and not on the emacs-devel mailing list, so his response is not publicly available and I will not quote it here.

Anyway, Michael said that the tried sql-indent and does not like it. His opinion is that SQL is too complex and a syntactic indentation mode would not work. He prefers sql-mode, as is, with basic indentation only.

Given his response, I will not pursue this any further.

If anyone wants to add this package to GNU Emacs, ELPA or MELPA, they are welcome to do so. For my part, I will continue to support this package here on GitHub.

from emacs-sql-indent.

phil-s avatar phil-s commented on August 28, 2024

I'm sorry to hear that. Thank you for trying.

from emacs-sql-indent.

PierreTechoueyres avatar PierreTechoueyres commented on August 28, 2024

@alex-hhh
I'm sad to read this, but not really surprised ...

Would you post your comment to the emacs-devel list ? At least to explain why you give up, in case someone is asking long time after.

from emacs-sql-indent.

alex-hhh avatar alex-hhh commented on August 28, 2024

this package has been added to GNU ELPA, see http://elpa.gnu.org/packages/sql-indent.html

from emacs-sql-indent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.