Coder Social home page Coder Social logo

Comments (3)

Alcaro avatar Alcaro commented on July 19, 2024

Spec doesn't permit ignoring the header at all, I made that part up myself. Ignoring the header should mean 100% ignoring the header, as if the patch was created from unheadered ROMs.

Can't reproduce. I tried all four combinations of headered and unheadered source and target ROM (where target has the bytes 12 34 56 78 inserted at offset 0 or 0x200, depending on if it's headered); the resulting patches are identical. (Though it does complain that the ROMs are backwards if source is headered and target isn't; fixed.)

from flips.

YoshiRulz avatar YoshiRulz commented on July 19, 2024

Added a Nix overlay for fdd5c6e and used --info --verbose, and the size is indeed 524288 (=0x80000), it's my implementation of the varint decoder that's wrong. Sorry about that.

from flips.

Alcaro avatar Alcaro commented on July 19, 2024

--info exists in 2021-10-28 too and will tell the expected file sizes. But you want the #57 fix, so overlay sounds good to me.

And you did point me toward one bug, so don't worry about it.

from flips.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.