Comments (8)
Hi!
thank you for opening the issue. I'll try to fix this as soon as possible.
Best regards.
from easytimer.js.
Thanks! I wouldn't have noticed it, except the tables sometimes get the same records added back after they were removed... and the items I was using for the ids of the spans were the same as the previous times the rows were in the table. This ended up causing really weird behavior, which I eventually tracked down to the fact that the span was being updated by multiple timers!
I've worked around that by just adding Date.now() to the id... but, I'm sure the timers take up at least some memory, so, being able to get rid of them completely would still be nice.
Also, the documentation doesn't clarify if you can call removeEventListener without the 2nd parameter, and have all listeners removed, or if the original callback is required. If not supported, it definitely would be nice to be able to remove all by not specifying a 2nd parameter.
from easytimer.js.
Hi again!
I can't reproduce the bug. I made a unit test of this function and it seems to work ok. If you can show me an example of the bug It will be easier to fix it. You can see the test here.
The removeEventListener function is a wrapper of the function with the same name in the EventTarget object. You can read the documentation here.
I could add the behavior of removing all listeners but is not the goal of this function, and I don't want to add more complexity to the library.
Thank you again!
from easytimer.js.
https://jsfiddle.net/8uuku5gs/5/
from easytimer.js.
Hi!
There is a typo in your example. You wrote t1.removeEventLister("secondsUpdated",cb); instead of t1.removeEventListener("secondsUpdated",cb);. If you change that it works as expected.
Best regards.
from easytimer.js.
Is there someplace I can send you a link to a secret gist? It has some proprietary code, so I don't want to make it publicly available.
from easytimer.js.
Of course, you can send me an email: [email protected]
from easytimer.js.
I can't reproduce the bug. I close the issue. If someone has an example, please reopen and I'll check it out.
from easytimer.js.
Related Issues (20)
- Start, Pause, Stop and Reset (Chronometer) example HOT 1
- display issue of secondTenths HOT 5
- Set timer values HOT 3
- Can't get easytimer load HOT 4
- Uncasted startValue yields incorrect timings HOT 2
- Add a way of clearing the event listeners array and remove by ID HOT 6
- If you pass seconds that are more than 86400, it doesn't display a day HOT 1
- object returned by getTimeValues() or getTotalTimeValues() is mutated as timer runs HOT 1
- Reset Timer doesn't reset to Zero if StartValue is not started from Zero HOT 1
- Timer is not defined HOT 1
- Without jQuery? HOT 2
- Double Digit Support HOT 3
- Hour > 24 HOT 2
- Error in guide HOT 1
- How to get secondHundreth? HOT 1
- How to reset timer after page reload/open new window with startValues. HOT 22
- Timer is not running but seconds are updated HOT 2
- Consider creating `.map` files. HOT 1
- Rewrite in typescript HOT 1
- Sometimes browsers throttle intervals which are faster than seconds HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from easytimer.js.