Comments (13)
just fixed thumbIndex.value === 0;
to thumbIndex.value = 0;
, and released to v2.1.2
, thanks found it.
also disableTrackFollow
still needs to check.
from react-native-awesome-slider.
https://github.com/alantoa/react-native-awesome-slider/pull/27/files
just created a PR, I think should fix both issues.
and released v2.1.3
.
from react-native-awesome-slider.
Just tested it, it works as it should. Thanks @alantoa, good work!
from react-native-awesome-slider.
disableTrackFollow
prop is the culprit. Trying to figure what is causing it.
from react-native-awesome-slider.
hey, @efstathiosntonas, its a bit repetitive during the swipe, so I remove thumb logic.
this is before video, maybe need to do adjust for this.
Simulator.Screen.Recording.-.iPhone.13.-.2022-09-23.at.16.53.29.mp4
from react-native-awesome-slider.
After going through the entire diff between 2.0.8 and 2.1.1 I realised that you're using ref only on the bubble so discard the intro on the initial comment. Something is causing the thumb to not move if disableTrackFollow
is enabled. Looking into it now.
from react-native-awesome-slider.
just check it, make sense!
maybe we just make the disableTrackFollow
change to Animated.SharedValue
, and turn it when isScrubbing=true
.
from react-native-awesome-slider.
we don't need it when isScrubbing = false.
from react-native-awesome-slider.
also, add you to manage of this lib, feel free to change it.
from react-native-awesome-slider.
Thanks for adding me as a collaborator. This useAnimatedReaction is causing the issue, at 2.0.8 the calculations where different.
edit: link:
react-native-awesome-slider/src/slide.tsx
Line 656 in 5a1fc1c
from react-native-awesome-slider.
This entire function is missing from 2.1.1
// setting thumbValue
useAnimatedReaction(
() => {
if (isScrubbing && isScrubbing.value) {
return undefined;
}
if (step) {
return undefined;
}
const currentValue =
(progress.value / (minimumValue.value + maximumValue.value)) *
(width.value - (disableTrackFollow ? thumbWidth : 0));
return clamp(currentValue, 0, width.value - thumbWidth);
},
data => {
if (data !== undefined) {
thumbValue.value = data;
}
},
[thumbWidth, maximumValue, minimumValue, step, progress, width],
);
when i added it back it worked as it should 🤔
from react-native-awesome-slider.
yeah, I didn't know you needed this before.
now I know you add isScrubbing
prop to work this, but I'm not sure other people will add isScrubbing
prop, I hope this component is simple to use.
so I think need an isScrubbingInner
value to use the inner component, that's prefect!
from react-native-awesome-slider.
It won't work if I remove the isScrubbing
prop and enable the disableTrackFollow
prop. Am I missing something on the "config"?
Just to be sure we're on the same page, this is how I'm using it:
Screen.Recording.2022-09-23.at.12.29.29.mov
from react-native-awesome-slider.
Related Issues (20)
- snapToStep doesn't work, the progress bar stays at the same place but the value changes HOT 2
- On initial render, progress shows incorrect value when `step` is set HOT 5
- How to set initial step? HOT 8
- Does this library support two thumb range selector? HOT 2
- Thumb "drag point" is not centered on thumb HOT 4
- Progress shows incorrect value when Step is set HOT 1
- isScrubbing is not set to false when tapping on the slider or thumb
- How to show the bubble always without animating HOT 2
- How to update current value? HOT 1
- The value of the progress bar is not refreshing. HOT 13
- React not defined HOT 5
- Remove the value text HOT 2
- Only allow drag input if user is holding onto the thumb HOT 2
- Slider is not interactive, can't move it HOT 1
- Slider don't show progress when is disable HOT 3
- Keyboard getting opened On slider touch HOT 2
- How to reset slider progress to 0 or default state HOT 8
- Thumb is not synced with slider HOT 4
- slider length is changing but marker/thumb is going out of range HOT 3
- Fatal Error with latest version of Reanimated HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-awesome-slider.