Coder Social home page Coder Social logo

Comments (6)

jshier avatar jshier commented on August 29, 2024

Thanks for the offer! Sure, if you can make the changes without affect current consumers, we'd be glad. I just merged a big infrastructure PR, so make sure you rebase from current master.

from alamofirenetworkactivityindicator.

benasher44 avatar benasher44 commented on August 29, 2024

In Swift 4.1, doing this gets a lot easier because we can use #if canImport(Alamofire) to guard against using the notification symbols in projects that don't use Alamofire, so I think I'll wait for that.

from alamofirenetworkactivityindicator.

jessesquires avatar jessesquires commented on August 29, 2024

@benasher44 Nice 😎

from alamofirenetworkactivityindicator.

jshier avatar jshier commented on August 29, 2024

@benasher44 I've updated to 2.2.1 for Swift 4.1, so you can begin when you want. However, I'm not sure we can ship a release that requires Swift 4.1 until we can finish and release Alamofire 5, which will require that version.

from alamofirenetworkactivityindicator.

benasher44 avatar benasher44 commented on August 29, 2024

Sounds good! I’ll try to get a PR up soon that requires Swift 4.1. That route I think will have the cleanest final API, and then we can wait until Alamofire 5 lands to merge it.

from alamofirenetworkactivityindicator.

benasher44 avatar benasher44 commented on August 29, 2024

Closing. See note about why in #34.

from alamofirenetworkactivityindicator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.