AggregatedTestExecutor (and other executors) do not properly close QueryExecutionFactory instances about rdfunit

[jimkont]

Thanks for the report @jeenbroekstra

I make TestSource AutoClosable which closes any open QueryExecutionFactory objects. When RDFUnit is used as a library the developer would be responsible for closing this (or instantiating it with try-with-resources).

Does this approach cover your use cases? if not, you can reopen the issue and we can find another solution

[abrokenjester]

Thanks for looking into this @jimkont. I think your fixes cover some cases, but there are a few other places where autocloseables are leaking - mainly because they are being daisy-chained in the try block instead of independently assigned. Let me put a PR together for you.

[abrokenjester]

Ah, hang on, I missed the bit where you fixed the close method in AbstractTestSource. Spoke too soon, this might cover our case (though part of the problem is that we use a custom implementation of TestSource that does not inherit from AbstractTestSource).

[jimkont]

Thanks! Any contribution/PR of of course more than welcome!

Would also be happy to refactor TestSource / AbstractTestSource if it results in a design that covers more use cases