Finish Mocking unit tests about akropolis-sale

[jakub-wojciechowski]

cap is calculated dynamically base on the baseCap, so it depends on round

[onigiri-x]

To solve this issue: Can we put together a test for this line?

[onigiri-x]

Edit: Have changed this issue to include the rest of the unit test lines that have not been tested:

Acropolis Crowdsale 28 & 29

Akropolis Presale 80 & 117

Increasing Cap Crowdsale 57

These lines might not need to be tested at all, but we should chat through them to see if we can find a strategy to test them

[jakub-wojciechowski]

I've added a pull request with extracting configuration parameters: #19

For testing we should create another contract: MockSaleConfiguration with methods allowing to overwrite these parameters.
In that way we'll be able to run tests across different configurations and verify even the constant params.

[onigiri-x]

Is there an example mock test we can reference? Will this be a new npm dependency such as “sinon.js” ?

[onigiri-x]

http://blog.kobigurk.com/mocking-ethereum-contracts/ This is a reference I have used, wondering if it is viable.

[davidprice35]

Hasn’t Truffle framework superseded this? With Javascript and Solidity testing or am I missing something ? From: victorwiebe [mailto:[email protected]] Sent: 23 January 2018 04:31 To: akropolisio/akropolis-sale <[email protected]> Cc: Subscribed <[email protected]> Subject: Re: [akropolisio/akropolis-sale] Finish unit tests (#13) http://blog.kobigurk.com/mocking-ethereum-contracts/ This is a reference I have used, wondering if it is viable. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#13 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABXf1s2hyeWxCxC_IIAWrc8GGuu_Pq6-ks5tNURZgaJpZM4Rj6Xp>.

[jakub-wojciechowski]

We are talking about ability to substitute contract constants with test values. The usual approach is to use mock/stub. Although, truffle has built in integration with testing frameworks like mocha or chai, there is no native support for smart contract mocking. We'll explore the tool suggested by Victor.

[onigiri-x]

Closing this out as Jakub has pushed out a mock config which works.