Coder Social home page Coder Social logo

Comments (10)

hseeberger avatar hseeberger commented on August 21, 2024

BTW, this has been introduced in commit d24c080.

from akka-stream-contrib.

patriknw avatar patriknw commented on August 21, 2024

I agree, that is wrong. Looks like we need a akka-stream-contrib-testkit

from akka-stream-contrib.

patriknw avatar patriknw commented on August 21, 2024

Or set it to provided

from akka-stream-contrib.

hseeberger avatar hseeberger commented on August 21, 2024

Set what to provided?

from akka-stream-contrib.

hseeberger avatar hseeberger commented on August 21, 2024

Maybe we need an akka-stream-testkit-contrib instead of akka-stream-contrib-testkit?

from akka-stream-contrib.

hseeberger avatar hseeberger commented on August 21, 2024

Should we revert the commit that introduced this bug and make a new release? For the time being ...?

from akka-stream-contrib.

patriknw avatar patriknw commented on August 21, 2024

I think it's easiest to set the akka-stream-testkit dependency to "provided". That means that user needs to add that dependency if the use the Coroner

from akka-stream-contrib.

hseeberger avatar hseeberger commented on August 21, 2024

I agree, that's the easiest, i.e. quickest, fix. On the long run that looks a little fishy to me.
Should I create a PR with the "provided" fix? If so, could you release a 0.5.1 soonish?

from akka-stream-contrib.

hseeberger avatar hseeberger commented on August 21, 2024

Here you are: #83

from akka-stream-contrib.

hseeberger avatar hseeberger commented on August 21, 2024

Thanks!

from akka-stream-contrib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.