Coder Social home page Coder Social logo

Comments (3)

johanandren avatar johanandren commented on August 22, 2024

Throwing sounds like the path to go to me. I can't think of any benefits from returning an empty default response message in a test scenario?

from akka-grpc.

alexklibisz avatar alexklibisz commented on August 22, 2024

I opened the original Lightbend support ticket requesting this. Thanks for opening here.

I think just throwing is fine. I'm trying to think why we used the Empty pattern, and can't remember a compelling reason. I just tried replacing Empty with Unimplemented in a couple places and it works fine.

One more consideration: in some cases we've also found it useful to have an object and/or method as follows:

object SomeApiClientStub {

  trait Unimplemented extends SomeApiClient {
    def someRpc(in: SomeRpcRequest): Future[SomeRpcResponse] = ???
  }

  object Unimplemented extends Unimplemented

  def unimplemented: SomeApiClient = new Unimplemented
}

This will be extremely helpful for reducing boilerplate in test suites. Thanks :)

from akka-grpc.

alexklibisz avatar alexklibisz commented on August 22, 2024

It might also be useful to throw a custom exception, roughly, final class AkkaGrpcStubNotImplementedException extends NotImplementedError, to make it more obvious that a stubbable, unimplemented method was called.

from akka-grpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.