[BUG] textDocument/formatting not supported on_attach about flutter-tools.nvim

[preiter93]

I have noticed something similar too, namely when trying to auto format on save, it isn't formatting. Guessing this is related?

yes, probably, that's how I noticed it too. I think it's common to have code like this

-- Autoformatting on save
if client.supports_method(“textDocument/formatting”) then
  vim.api.nvim_create_autocmd(“BufWritePre”, {
    buffer = bufnr,
    callback = function()
      vim.lsp.buf.format({ bufnr = bufnr })
    end,
  })
end

which runs in the lsps on_attach. Thats is currently not working. As a workaround I removed the check

if client.supports_method(“textDocument/formatting”) then

for flutter/dart.

[JordanllHarper]

I have noticed something similar too, namely when trying to auto format on save, it isn't formatting. Guessing this is related?

[CnTeng]

Close the opened flutter buffer, and reopen it.
Then all the supports_method check will pass, and inlay_hint will show correctly.
It's weird, but works.

[sidlatau]

I think this is related to neovim/neovim#23681, now document formatting, code actions, and inlay hints have the property dynamicRegistration=true. If I set it to false here https://github.com/akinsho/flutter-tools.nvim/blob/990a1349c29f7d474a0cd51355aba773ccc9deea/lua/flutter-tools/lsp/init.lua#L95 or in local config then client.supports_method(“textDocument/formatting”) returns true. But I am not sure what is the correct fix here...

[sidlatau]

I investigated this a bit more, here is more information about the problem: neovim/neovim#24229

It is not enough now to check capabilities on LspAttach, it may return false, but then the capability may be registered dynamically and the next check will return true.
Workarounds for this may be to switch back to static registration:

flutter_tools.setup {
  lsp = {
    capabilities = {
      textDocument = { formatting = { dynamicRegistration = false } },
    },
}

Or do additional check in client/registerCapability handler:

local orig_handler = vim.lsp.handlers["client/registerCapability"]
vim.lsp.handlers["client/registerCapability"] = function(err, result, ctx)
  local orig_result = orig_handler(err, result, ctx)
   -- do something
  return orig_result
end

As this is not a plugin bug I will close this issue.