Cannot change user password when "Display badge for all users" is ON about redmine_issue_badge

[akiko-pusu]

Hi, @nakat-t
Thank you so much for your reporting this problem, any information is highly appreciated.
I’m going to review and fix soon.

[akiko-pusu]

@nakat-t
I could reproduce above situation, and thank you so much your information again.
As you supposed, this is because ajax request to issue badge controller is blocked and redirected in case user is required password change, due to application controller.

Here is a quick workaround:

1. Prevent to render contend in case ajax request is redirected and not include issue badge template.

--- a/assets/javascripts/issue_badge.js
+++ b/assets/javascripts/issue_badge.js
@@ -5,7 +5,9 @@ function load_badge(url) {
         async: true,
         type: 'get'
     }).done(function( html ) {
-        $('#loggedas').after(html);
+        if ($(html).filter('div#issue_badge').length) {
+            $('#loggedas').after(html);
+        }
     });
 }

2. Prevent to load javascript in case user is required password change.

--- a/lib/issue_badge/application_hooks.rb
+++ b/lib/issue_badge/application_hooks.rb
@@ -6,7 +6,7 @@ module IssueBadge
       base_url = Redmine::Utils.relative_url_root
       badge_url = base_url + '/issue_badge'
       o = ''
-      if User.current.logged?
+      if User.current.logged? && User.current.change_password_allowed?
         global_enabled = Setting.plugin_redmine_issue_badge['activate_for_all_users'] == 'true'
         o = stylesheet_link_tag('style', plugin: 'redmine_issue_badge')
         if User.current.pref.issue_badge || global_enabled

Anyway, I’m going to fix this as soon as possible.

[akiko-pusu]

I’ve applied bug fix into master branch. Thank you so much!

[nakat-t]

I verified that it was fixed in master. Thank you very much for your work.