Comments (5)
It does not make sense having to call a function. If you have to make a change in your code you might just as well change the namespace. That's the whole point of the aliasing. I changed the code to do preloading and will release a new version.
from s3.
PHP cannot load class aliases on demand. Loading classes on demand only works with the autoloader, but the autoloader will only work if the original class (as requested) is found, unfortunately. If you know of another way to do that, please let me know.
from s3.
@nikosdion thank you for the feedback, I mean call some function which will make aliasing for old paths with preloading (all the code in aliasing.php), so to migrate to new version without changing code, only one function will need to be called. Now unfortunately the library is broken, aliasing.php isn't working, it doesn't adding aliasing and generate errors.
from s3.
FWIW the latest semantically versioned tag (2.2.2) predates the namespace change, i.e. the library was never broken. If you use it via composer with its semantically versioned releases you never saw it breaking. I have not released 2.3.0 yet.
The development branch is exactly that; under development. Occasionally things break. Just because I push into the branch doesn't mean it's working code. In this case I pushed code before traveling so my code is not just on a laptop which could get lost, broken etc. I just never had the chance to come back to this to test its integration with other software relying on the legacy namespace.
BTW, if you're using the development branch, the commit a5dbdc2 already fixed that problem so you're one composer update
away from getting your downstream fixed.
from s3.
Great, thank you @nikosdion
from s3.
Related Issues (20)
- Support for Digital Ocean Spaces? HOT 3
- Documentation without using Composer HOT 14
- getAuthenticatedURL with HTTPS? HOT 3
- Solved: PHP Config Issue - small file upload works, files over 2MB fail HOT 8
- Question: Syntax for Creating Folders HOT 1
- Check if an object exists on S3 HOT 3
- Error::setCode() throws TypeError HOT 4
- getBucket() and file timestamp HOT 5
- getBucket() looks like there is a limit of 999 files HOT 4
- getBucket() $maxKeys usage HOT 1
- Cannot upload empty files - Missing input parameters HOT 3
- Presigned upload URLS HOT 3
- getAuthenticatedURL does not honor setUseLegacyPathStyle HOT 1
- getObject cannot get XML files HOT 2
- Any way of testing from localhost? [Question] HOT 1
- Receiving SignatureDoesNotMatch errors after upgrading from 2.0.0 HOT 2
- Upgrading from version 2.0 HOT 6
- Add an option to switch between `X-Amz-Date` and `Date` HOT 1
- Support for DreamObject s3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s3.