Comments (11)
Maybe I'm too pedantic with this but I see this as a first sign in terms of the broken window theory (Short: Let one thing slide, the rest will follow and with it the demise of the project). I actually introduced a lot of the code changes (Grunt, testing, automation) to make it easier to check for such errors on a regular basis and plan to get this onto travis and track the progress with migrations towards a cleaner codebase.
I'll give updates to these efforts in a bit.
@bluesmoon what do you think?
from boomerang.
We've selected the eslint rules to force what we want the project to be. In particular, eslint failure needs to force the Makefile to fail so that subsequent rules aren't executed (for example if you have rules to push to your production server).
@andreas-marschke that's a good idea, but I'd speak to @nicjansma about the testing framework to use.
from boomerang.
IMO, I do not want the build to fail even for a specific multi-space and comma-spacing issues.
Would be better if we can throw warnings instead of errors. Can send a pull request if you are aligned.
from boomerang.
No, like I mentioned in the previous comment, I really do want the build to fail in these cases. Coding style is very important and it's important to keep it clean.
from boomerang.
Makes Sense. Check the errors that are thrown on the build time.
How do you want to proceed on this?.
from boomerang.
from boomerang.
I am using version - 0.17.0
from boomerang.
Filed a bug on eslint: eslint/eslint#2077
from boomerang.
Awesome 👍
from boomerang.
from boomerang.
super cool :)
from boomerang.
Related Issues (20)
- Support for JAMStack-style single page apps? HOT 5
- Is it possible to use autoxhr plugin without rt plugin? HOT 22
- Which event should I subscribe to control header value? HOT 1
- Can we use Boomerang to send custom metrics/logs? HOT 1
- Bug: Trying to read metric from plugin that is undefined HOT 1
- How does the Cache-Reload Plugin works HOT 3
- API Key Disclosure HOT 2
- how about to move Plugins to webworker
- Integrate Plugins into asynchronous loader snippet HOT 5
- Continuity Visually Ready (c.tti.vr) gradually increased in Chromium 105 and 106 HOT 3
- What event should I subscribe to to know when the fetch is complete HOT 2
- t_done,t_page and rt.tt values are negative on SPA HOT 21
- Global collision issue HOT 2
- about web vital score HOT 1
- How to know user spent time on page HOT 6
- soft navigation not stop
- disable page unload beacon HOT 2
- Potential forced style layout HOT 5
- What is the use of the last_location function in spa plugin HOT 2
- SPA beacon is blocked if link href value is updated after soft navigation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from boomerang.