Coder Social home page Coder Social logo

Comments (9)

bluesmoon avatar bluesmoon commented on May 27, 2024

There's a bug starting with Firefox 31. Can you check if this is fixed on
bluesmoon/boomerang?

I had to change if(window.performance) to if("performance" in window). You
may have to do that for the resource timing plugin.

Philip
On 6 Oct 2014 07:21, "Phil Booth" [email protected] wrote:

I've built the current master with the rt and NavigationTiming plugins.
Using Firefox 32.0.3, no beacon request is received by my server, whereas
with Chrome 37.0.2062.124 the beacon request is received correctly.

Using the debug build, the console log looks the same in both browsers, no
errors.

I also set a breakpoint in sendBeacon() in Firefox, where the image is
created and that works fine. But the network tab shows no request being
made (although I'm less familiar with Firefox dev tools, so this could be
user error) and the server definitely receives nothing.

Have you seen or heard of any similar issues, or do you have any ideas
about what might be wrong?

—
Reply to this email directly or view it on GitHub
#39.

from boomerang.

philbooth avatar philbooth commented on May 27, 2024

So bluesmoon:master looks exactly the same as lognormal:master to me (commit 51d1be7 / 12th August). Or did you mean a different branch in bluesmoon/boomerang?

from boomerang.

bluesmoon avatar bluesmoon commented on May 27, 2024

No that's it.

The fix I made was here, although you only need to check if ("performance" in window):
4dff5da

I suspect it also needs to be done here:
https://github.com/lognormal/boomerang/blob/master/plugins/restiming.js#L28

from boomerang.

philbooth avatar philbooth commented on May 27, 2024

Okay, thanks for the tip.

Actually, I've had a closer look and my issue is way weirder and more fundamental than that. If I remove boomerang from the equation entirely and load the following document, I can reproduce the problem:

<!DOCTYPE html>
<html>
    <head>
        <script>
            var image = new Image();
            image.src = 'http://localhost:8080/beacon?foo=bar';
        </script>
    </head>
</html>

But if I remove the query string from the image URL, the server receives the request:

<!DOCTYPE html>
<html>
    <head>
        <script>
            var image = new Image();
            image.src = 'http://localhost:8080/beacon';
        </script>
    </head>
</html>

Presumably Firefox on my machine is borked somehow. Going to delete it, reboot, then reinstall and hopefully that will set me right.

from boomerang.

bluesmoon avatar bluesmoon commented on May 27, 2024

Interesting. If it doesn't fix it, we may have to look at this in more detail. I've actually been looking at a complete form based beaconing system. It makes the code much simpler with resource timing. We're also looking at compressing the resource timing data before beaconing. Will get you to review when we're satisfied with the results.

from boomerang.

philbooth avatar philbooth commented on May 27, 2024

So the problem persists after reinstalling. I don't have another machine to try it out on at the moment, but maybe it's a genuine feature.

However, the problem does not occur if I request a URL that contains a file extension. The file extension itself doesn't seem to matter; .png, .php, .html and .wibble all worked fine. So it's easy for me to avoid this now, perhaps everyone else is doing it already?

I'm happy to make a pull request against the documentation calling this out explicitly if you like. I guess the correct place would be for the beacon_url param in /doc/api/BOOMR.html. Anywhere else?

from boomerang.

philbooth avatar philbooth commented on May 27, 2024

Fwiw, I've raised this in Bugzilla as well:

https://bugzilla.mozilla.org/show_bug.cgi?id=1079158

from boomerang.

bluesmoon avatar bluesmoon commented on May 27, 2024

Thanks. Yeah, putting this in the docs would be useful.

from boomerang.

philbooth avatar philbooth commented on May 27, 2024

So in the course of investigating the Firefox issue, after rebooting I can no longer reproduce it. Seems like it may have just been weirdness on my dev machine after all.

Sorry for the time-wasting, I'll leave the docs as they are and close this issue.

from boomerang.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.