Comments (4)
In your examples, you use a scope of minor
for the final stage, but use patch
for milestone and rc. I think that's the cause of the difference you see.
If you pass empty strings or just don't add the properties at all, it will leave the version as is if the commit is already tagged.
But maybe I'm not following your desired behavior.
from reckon.
ohm .. sorry @ajoberstar
- for the "delay"
- for the bad example
BUT even, the inconsistency is still there
bash:$ git describe
0.0.1
bash:$ ./gradlew build -Preckon.scope=patch -Preckon.stage=final
> Configure project :
Reckoned version: 0.0.2
while rc or milestone resolve to tagged 0.0.1
another way round, even -Preckon.scope=minor -Preckon.stage=rc
and -Preckon.scope=minor -Preckon.stage=milestone
are 0.0.1
while final bumps to 0.1.0
as shown above
so, is there a reason for this "final" is handled differently on tagged commits?
from reckon.
Reckon tries to determine if you intend to "rebuild" the tagged commit. Usually this is determined by whether you provide input or not via the properties. If it's a tagged pre-release, you have more flexibility. If it's a tagged final version, it only lets you re-release it as another final version. It's mostly an intention to not allow potentially "invalid" increases in the version. In some cases they might be too restrictive.
Which version are you on? The rebuild behavior was rewritten recently. Off the top of my head, I'm thinking that providing input (via properties) should prevent it from doing a rebuild (ideally failing).
from reckon.
hi andrew,
yes indeed, I was on some old stuff hanging around, your "rebuild" behaviour now rejects re-releasing tagged finals other than final.
these new build failure indications with your explanations made this clear.
thank you
from reckon.
Related Issues (20)
- Reckoned version has already been released HOT 1
- NPE: Must provide a scope supplier HOT 4
- Wrong insignificant tag generated when using maintenance branches with patch releases HOT 21
- `+` in reckoned insignificant version is not docker tag compatible HOT 3
- Unable to create minor version when release candidate is in review HOT 11
- gradlew build create a scope version issue - How to fix it? HOT 4
- Reckon cannot determine correct action when infering version in bitbucket pipeline HOT 1
- reckon failing in trunk based development HOT 1
- Best practices for local development with the Reckon-Plugin HOT 9
- Cannot release a final or significant stage without a clean repo error even though repo is clean HOT 2
- Plugin [id: 'org.ajoberstar.defaults.gradle-plugin', version: '0.17.1'] was not found HOT 2
- gradle build version number value not incrementing
- gradle build version number value not incrementing HOT 1
- Hiding errors on release 0.16.1 HOT 1
- defaultInferredScope should either have no default or default to patch
- How to set the stage for an included build when using composites. HOT 1
- use of deprecated Gradle function
- Settings plugin: tag and push task creation could be done a little earlier
- [Feature request] Support Gradle configuration cache
- Cron builds in Github Actions result in `Scope between bases` error HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reckon.