puma does not restart after deploy that changes only environment variables about opsworks_ruby

[ajgon]

I created a PR #282 to address this issue, can you please take a look if it works for you? If so, I'll merge it to the codebase and release a new version of the gem.

Thanks!

[kzkn]

@ajgon
Great, it works fine!

[kzkn]

This seems to be similar to the problem we addressed in #251.
Enviroment variables are embed in monitrc files. So environment variables change causes monit reload. If appserver and worker is used in a instance both, monit reload is called twice. One for appserver's monitrc, one for worker's monitrc.

In the log, the second Reinitializing Monit -- control file '/etc/monit/monitrc' cancels 'puma_rails' restart on user request.

[kzkn]

It seems to work if we use creates to limit the execution of monit reload to one time. Like this:

# configure.rb
every_enabled_application do |application|
  # snip

  timestamp = Time.now.to_i
  execute 'monit reload' do
    command "monit reload && touch /tmp/.monit-reload-#{timestamp}"
    action :nothing
    only_if 'which monit'
    creates "/tmp/.monit-reload-#{timestamp}"
  end
end

[kzkn]

@ajgon #282 does not work 😢 And I found a new issue #284.
Even if pumactl restart is successfully to run, it will not resolve #284.

I think it is not necessary to embed environment variables in monitrc for puma.

If we are using dot_env, it does not override environment variables already defined by default. If we set values in monitrc, puma worker processes will not reflect it even if the .env value changes.

If we do not include environment variables in monitrc, changes in .env values will be reflected to puma worker processes.

And puma's monitrc is not changed before/after the deploy which has the change of environment variables, it avoids monit reload for puma. Therefore, puma will restart even after a deployment in which environment variables have been changed. In other words, this issue (#281) is resolved.

My patch is here: kzkn@ba95731

[ajgon]

@kzkn I added your patch here: b6fa01f - would it work for you?