The provider code doesn't compile about terraform-provider-aiven

[FranOis]

@robertofpaf Hi, I haven't been working on this in on long while. You are correct that it would require a new version if you don't want to work off of master. My setup was to have both in my go path and develop from my local branches.

I'm not sure what the process of doing a release would be for the aiven client. @jelmersnoeck Would be the one to contact.

@FranOis I'm working out of master, but the problem is that the changes required in the aiven client (MFA support and auth tokens for users) are in the master branch of your fork (https://github.com/motivateco/aiven) and not in the master branch of the original project (https://github.com/jelmersnoeck/aiven). And your fork is 11 commits behind, so I would believe the best thing to do would be to try and merge your fork back...

[FranOis]

Our master is out of date, but the NewMFAClient still exists in the original project as far as I can tell: https://github.com/jelmersnoeck/aiven/blob/master/client.go#L27

Ok, I definitely don't understand how glide works as git was reporting that it was in the master branch, git pull didn't pull any change but the local client.go I had was very outdated. Now I've checked out directly the master branch of the aiven client and the MFA part passes. However I'm still getting errors about the access certificate and key:

go build -o terraform-provider-aiven .
# github.com/pafinfra/terraform-provider-aiven
./resource_service_user.go:79:27: user.AccessCert undefined (type *aiven.ServiceUser has no field or method AccessCert)
./resource_service_user.go:80:26: user.AccessKey undefined (type *aiven.ServiceUser has no field or method AccessKey)
./resource_service_user.go:102:29: user.AccessCert undefined (type *aiven.ServiceUser has no field or method AccessCert)
./resource_service_user.go:103:28: user.AccessKey undefined (type *aiven.ServiceUser has no field or method AccessKey)
Makefile:2: recipe for target 'plugin' failed
make: *** [plugin] Error 2

Those fields are not defined in user.go in the aiven client master branch: https://github.com/jelmersnoeck/aiven/blob/master/user.go

[jelmersnoeck]

Hey @robertofpaf. Thanks for highlighting this.

This is actually associated with the ServiceUser. It seems that https://github.com/jelmersnoeck/terraform-provider-aiven/issues/8 added a change here for the Aiven client, but this wasn't patched.

@FranOis could you do the appropriate patch for the Aiven Client as well?

I will look at setting up CI for this project soon.

@FranOis What is the situation here?

@jelmersnoeck Should I just send a PR that undoes https://github.com/jelmersnoeck/terraform-provider-aiven/pull/9 to get the code compiling?

Ok eventually submitted https://github.com/jelmersnoeck/aiven/pull/10, it brings back the 2 field that got deleted (I guess by mistake) in https://github.com/jelmersnoeck/aiven/pull/4 and the provider now compiles.

[FranOis]

@robertofpaf thanks for the PR, it's merged.

[FranOis]

@robertofpaf what's the status? can we close? seems like everything is compiling.

Ah, I thought this was closed when the PR was merged already.