Add "version" to Order object and get*Order calls to indicate the Swap contract intended for settlement about airswap-protocols

[hensha256]

This seems fair.
A malicious person could still deploy a swap contract with the same version though. So it could make more sense for the swap contract address to be specified in the order not the version

[dmosites]

Yes, sorry. Meant to say that the value of version would be a Swap contract address.

[hensha256]

Ah I see. I thought you meant the DOMAIN_VERSION constant that already exists.

[poiresel]

If that's the case, then maybe modify the Types.hashDomain to use the order.version if that's the new verifying contract? Also recommend calling it versioningAddress / versioningContract or something else appending to indicate this is a contractAddress and not just a a version 1 or 2

[dmosites]

If that's the case, then maybe modify the Types.hashDomain to use the order.version if that's the new verifying contract? Also recommend calling it versioningAddress / versioningContract or something else appending to indicate this is a contractAddress and not just a a version 1 or 2

The EIP-712 domainSeparator is calculated by hashDomain at deploy time for each Swap contract, not on a per-order basis. As for naming, agree it should be clear, though it could be clear simply to see that the values and types are addresses.

[cloudonshore]

Agreed!

[poiresel]

dmosites 3:03 PM
signatureValidator is flat
signature.validator is nested
it would be a part of Signature struct

[poiresel]

Close as #265 has been merged