Comments (8)
This seems fair.
A malicious person could still deploy a swap contract with the same version though. So it could make more sense for the swap contract address to be specified in the order not the version
from airswap-protocols.
Yes, sorry. Meant to say that the value of version
would be a Swap contract address.
from airswap-protocols.
Ah I see. I thought you meant the DOMAIN_VERSION
constant that already exists.
from airswap-protocols.
If that's the case, then maybe modify the Types.hashDomain to use the order.version if that's the new verifying contract? Also recommend calling it versioningAddress / versioningContract or something else appending to indicate this is a contractAddress and not just a a version 1 or 2
from airswap-protocols.
If that's the case, then maybe modify the Types.hashDomain to use the order.version if that's the new verifying contract? Also recommend calling it versioningAddress / versioningContract or something else appending to indicate this is a contractAddress and not just a a version 1 or 2
The EIP-712 domainSeparator
is calculated by hashDomain
at deploy time for each Swap contract, not on a per-order basis. As for naming, agree it should be clear, though it could be clear simply to see that the values and types are addresses.
from airswap-protocols.
Agreed!
from airswap-protocols.
dmosites 3:03 PM
signatureValidator is flat
signature.validator is nested
it would be a part of Signature struct
from airswap-protocols.
Close as #265 has been merged
from airswap-protocols.
Related Issues (20)
- Swap.check does not account for null sender.wallet values (i.e. public order)
- ERC721 allowance checks should call `getApproved` instead of `isApprovedForAll` HOT 1
- Add `proxyingFor` support to Server in `@airswap/libraries`
- Update Server with latest protocols (@airswap/libraries) including getPricing
- Remove defaultProviders from tests
- Add RPC endpoints to @airswap/constants; add to CLI
- New delegate contract (on-chain rules; limit orders)
- Update workflows to use node 16.x
- Upgrade project dependencies to latest
- Create a package version / dependency consistency script / precommit
- Review registry contract; rollout updates
- New pool contract (bulk claim approvals; unsigned claims)
- Add `Storage` protocol to constants and finalize `StorageERC20`
- Deploy contracts to Sepolia testnet
- Add protocols cost to Registry; refactor
- Include "proposal ID" (provided by Snapshot) with each root enabled on Pool
- Delegates
- Protocols 4.2 Launch
- https://github.com/airswap/airswap-protocols/issues/new
- Proposal to stop checking chain-id
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from airswap-protocols.