get_git_revision failed error about pybrake

[vmihailenco]

I believe it is possible if you configure logging for pybrake - see https://github.com/airbrake/pybrake/blob/master/pybrake/utils.py#L5 and https://docs.python.org/3/library/logging.html

[srininara]

This does not seem to be a logging issue. If the docker image does not contain .git folder contents in it (because of .dockerignore), then the init of Notifier class raises an exception because the HEAD file is not present. This breaks pybrake initialization itself. Is it possible to change pybrake such a way that it does not require the HEAD file?

[vmihailenco]

What exception is thrown in your case?

[srininara]

pybrake - ERROR - get_git_revision failed: [Errno 2] No such file or directory: '/<project_name>/.git/HEAD

This is through from Notifier init method and hence the notifier initialization fails and hence cannot be used any more.

[vmihailenco]

That looks like a log message from pybrake logger. Besides it should disappear if you upgrade to v0.4.0, but it is still in beta.

[srininara]

Not sure it is from the logger. I think the place where this breaks is this:

pybrake/pybrake/git.py

Line 49 in 9693af1

with open(head_file) as f:

And the call from notifier to this happens from here:

pybrake/pybrake/notifier.py

Line 71 in 9693af1

rev = get_git_revision(git_dir)

Just want to confirm if this is already fixed in v0.4.0. Also please let me know when will the version be out of beta and into GA?

[vmihailenco]

Those exceptions should be handled in

pybrake/pybrake/git.py

Lines 11 to 13 in 9693af1

	except (OSError, IOError) as err:
	logger.error("get_git_revision failed: %s", err)
	return None

We still need more time to release v0.4

[gabelimon]

Can we get this ticket reopened? I'm seeing the same error on heroku. It would be nice if it would pick up the SOURCE_VERSION

[vmihailenco]

It is better to make sure you are using the last version and open a new issue with as much details as possible.