Flask integration order of filters does not apply blocklist to request object about pybrake

[danman01]

I would suggest removing this bit from notifier.py#__init__:

# maybe with a flag, like add_blocklist_filter = False ?

keys_blacklist = kwargs.get(
            "keys_blacklist", [re.compile("password"), re.compile("secret")]
        )
        self.add_filter(make_blacklist_filter(keys_blacklist))

and adding this in flask.py#init_app:

notifier.add_filter(request_filter)
# previous code...
#
keys_blacklist = app.config["PYBRAKE"].get(
            "keys_blacklist", [re.compile("password"), re.compile("secret")]
        )
self.add_filter(make_blacklist_filter(keys_blacklist))
#
# rest of code...

Also, I can't figure out why my version doesn't have the new keys_blocklist name, even though versions seem to match...my url in Pipfile is https://pypi.org/simple

[scottsbaldwin]

@salonijain0918 is looking into this now...

[smurf-U]

@scottsbaldwin It's now resolved and updated version released.

[kyrylo]

@smurf-U you can close issues once a corresponding PR is merged.