y does not yank to clipboard about amvim-for-vscode

[aioutecism]

Answered #166 (comment)

[aioutecism]

VSCode's API only allows copy selections to system clipboard now.
I can let y to make a selection then copy to clipboard, but this will make selections "blink".

Instead, I'd recommend you create a custom map to call the built-in copy command.
This can be done by:

1. Open command palette.
2. Search for Preferences: Open Keyboard Shortcuts.
3. Create a new map with your favorite key and command editor.action.clipboardCopyAction.

[lf94]

Is the selections blinking just a UI effect? Maybe we can get the VSCode guys to add a user setting to turn it off?

[aioutecism]

Instead of turn the effect off, it would be better if they let extensions access system clipboard.

Vim uses the + register to do this. "+y and "+p to copy and paste.

If we support that, we'll need to have some notion of registers, which doesn't exist right now.

[jcrben]

Cross-referencing another clipboard issue: #166

[karlhorky]

it would be better if they let extensions access system clipboard

I guess VS Code has this ability, since VSCodeVim has this option to use the system clipboard...

Not sure exactly where it is in the codebase, but there are a few references that appear with a search:

https://github.com/VSCodeVim/Vim/search?q=system+clipboard&unscoped_q=system+clipboard

[karlhorky]

So I've found some keybindings that seem to work here! 🥳

  // Yank (copy) to system clipboard in VISUAL and VISUAL_LINE modes
  {
    "key": "y",
    "command": "editor.action.clipboardCopyAction",
    "when": "editorTextFocus && amVim.mode == 'VISUAL' && !inDebugRepl &&!suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },
  {
    "key": "y",
    "command": "editor.action.clipboardCopyAction",
    "when": "editorTextFocus && amVim.mode == 'VISUAL LINE' && !inDebugRepl &&!suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },
  {
    "key": "y y",
    "command": "editor.action.clipboardCopyAction",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl &&!suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },
  // Delete (cut) to system clipboard in VISUAL modes
  {
    "key": "d",
    "command": "editor.action.clipboardCopyAction",
    "when": "editorTextFocus && amVim.mode == 'VISUAL' && !inDebugRepl &&!suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },

Caveats

• The active selection from the VISUAL modes stays with the yank keybindings

I'm also uncertain why I don't need to match for VISUAL LINE mode with the d keybinding - it just works in both modes. Maybe more mode bugginess?

---

There is one more binding that I originally wrote to paste from system clipboard in NORMAL mode, but it pastes even in INSERT mode 😳 (I guess there's some issue with the modes):

  // Paste from system clipboard only in NORMAL mode (not working - pastes also in INSERT mode)
  {
    "key": "p",
    "command": "editor.action.clipboardPasteAction",
    "when": "editorTextFocus && amVim.mode == 'NORMAL' && !inDebugRepl &&!suggestWidgetMultipleSuggestions && !suggestWidgetVisible"
  },

@aioutecism can you comment on why the mode check is not working here? I tried looking through the code, but I'm really lost there...

[karlhorky]

I can let y to make a selection then copy to clipboard, but this will make selections "blink".

@aioutecism Also - would you consider adding this and an option for turning on this mode? I think there must be also a way to do it without the blinking (VSCodeVim achieves this somehow), but even with the blinking, it would be better than no copy to system clipboard (and also better than my hotkeys workaround).

[karlhorky]

Asked in #166 (#166 (comment)) about having some instructions about how to add this feature (as well as paste from system clipboard):

#166 (comment)

[karlhorky]

My first shot at a pull request up at #260.

[karlhorky]

Done in master (#260 was merged)! Will be released soon.

#272 contains documentation of the option.