Comments (4)
Comment by JunhanHu-aion (on Wednesday May 09, 2018 at 17:42 GMT)
Can confirm that java.lang.VerifyError will be raised by VM in case of a operand stack overflow.
I'm investigating how to properly use asm library to set the max operand stack size. MethodVisitor.visitMaxs() seems not setting the limit as we intended.
from avm.
Comment by jeff-aion (on Wednesday May 09, 2018 at 18:00 GMT)
I believe that is over-ridden by built-in ASM logic, via new ClassWriter(ClassWriter.COMPUTE_FRAMES);
We might need that for things other than operand stack and variable count, though. I think it is also used to compute the stack map, which is probably tricky to do manually.
from avm.
Comment by JunhanHu-aion (on Wednesday May 09, 2018 at 21:25 GMT)
Test created as org.aion.avm.core.instrument.BytecodeVerificationTest
Local variable table overflow and Operand stack overflow can be detected by JVM before execution.
from avm.
Comment by JunhanHu-aion (on Thursday May 10, 2018 at 15:47 GMT)
Confirmed the loop cases wont break the verifier. Stack map frame can stop the loop from keeping push to the operand stack. Test cases created inside BVT.
from avm.
Related Issues (20)
- Why are addresses 32 bytes? HOT 2
- Tests for address fail to differentiate wrapping HOT 2
- Remove Blockchain.getStorage / Blockchain.putStorage HOT 12
- Why is there no static initializer on Address? HOT 1
- Why is it necessary to use ABIStreamingEncoder and avmRule.call? HOT 3
- Clarify use case for hybrid storage
- Add support for BigInteger
- Specification request -- hashcode uniqueness HOT 2
- Turn on and link to continuous integration results
- BigInteger check should throw not assert HOT 2
- (!) BigInteger should specify range explicitly HOT 2
- Type safe storage API HOT 1
- There should be a deploy method for the main class HOT 2
- Assertion failure during contract deployment HOT 2
- Blockchain.log fails with null topic HOT 1
- Blockchain.log padding behavior is not specified
- AvmRule produces too much output in the default case HOT 4
- Missing diagrams in README
- For more security spongycastle -> bouncycastle
- Issue between AionMap and AionList HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from avm.