Coder Social home page Coder Social logo

Comments (7)

mikenerone avatar mikenerone commented on September 26, 2024

Having thought about it, I'm more on the fence about which behavior is more correct. The title-style output makes sense for HTTP headers. :/

from multidict.

asvetlov avatar asvetlov commented on September 26, 2024

In this case Cython version is correct, pure Python should be fixed

from multidict.

mikenerone avatar mikenerone commented on September 26, 2024

Cool, I'll be happy to make a PR if you like. I can be a contributor for just deleting one line. :P

Well, I suppose I'd provide a test or two, as well.

from multidict.

asvetlov avatar asvetlov commented on September 26, 2024

Please do.
Thank you for report

from multidict.

webknjaz avatar webknjaz commented on September 26, 2024

I can be a contributor for just deleting one line.

One line and a test, please:)

from multidict.

mikenerone avatar mikenerone commented on September 26, 2024

I noticed the same effect in the Python implementation in several of the places where a KeyError is raised, where the error message includes the title-ized key instead of the key passed by the caller (again, unlike the Cython implementations, which handle this correctly). As it's basically the same logic error, would you like me to fix these in the same PR or make a separate one?

from multidict.

asvetlov avatar asvetlov commented on September 26, 2024

Yes, casing should be preserved as Cython version does.

from multidict.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.