Monitor hangs on context manager exit about aiomonitor

[jettify]

Yeah, I suspected that my clean up logic was not good.

Issue in async python REPL server, we expose it on separate port so user can directly connect and bypass regular aiomonitor. It is hard to make proper clean up here. One solution is disable this bypassing feature and start and stop server on demand.

[jettify]

are you calling close() method inside coroutine?

[agronholm]

This is the complete module in which I start and stop aiomonitor:

from aiomonitor import Monitor, MONITOR_PORT, CONSOLE_PORT
from asphalt.core import Component, Context, context_teardown


class AIOMonitorComponent(Component):
    def __init__(self, host: str = '0.0.0.0', port: int = MONITOR_PORT,
                 console_port: int = CONSOLE_PORT, console_enabled: bool = True) -> None:
        self.host = host
        self.port = port
        self.console_port = console_port
        self.console_enabled = console_enabled

    @context_teardown
    async def start(self, ctx: Context):
        with Monitor(ctx.loop, host=self.host, port=self.port, console_port=self.console_port,
                     console_enabled=self.console_enabled):
            yield

On aiomonitor 0.3.1, this works fine.

[jettify]

0.3.1 did not close resources correctly as results tests were unstable... I never designed monitor to start inside coroutine. I think there should be separate API for async mode.

[jettify]

This PR should fix an issue #175

I decided to start and end python console server on demand and close it after exit, this way code is cleaner.