Http over unix socket about aiohttp

[fafhrd91]

How about custom scheme, something like unix://socket-path/path ?

[tailhook]

Not sure it's a good idea for two reasons:

1. socket-path should be percent-encoded? (may contain slashes)
2. https can be used too (unix+https://socket-path/path?)

I prefer some kwarg to a request or a session.

[fafhrd91]

i don't like percent-encoding also, but in that case we can move connection to to separate Connector class/function and remove loop.create_connection from session and client.

how about connector parameter? something like:

   aiohttp.request('get', ..., connector=UnixDomainConnector('/tmp/...'))

then it would be possible to create http proxy connector for example

what do you think?

[tailhook]

Yes. Sounds great

[fafhrd91]

Paul, do you want to work on this?

[tailhook]

Sure, unless you want to do it quicker :)

[fafhrd91]

go ahead! :)

[paultag]

I'd love this feature oodles! Just adding a 👍 - thanks for working on this!

[fafhrd91]

@tailhook let's wait with session integration with connector. i'd like to think about such integration.

[tailhook]

@fafhrd91, ok, I don't need the feature itself. The debatable question, is that connector might be better used for connection pooling, instead of session. And session left only for cookie handling.

Anyway, feel free to close the issue if you think it done.

[paultag]

I'd really be able to use this feature; I'd be happy to test code or whatever :)

It'd be super useful!

[fafhrd91]

@tailhook i agree about connection pooling, this is exactly what i'm planing to think about.

[tianon]

👍 consuming HTTP over unix sockets via aiohttp would be excellent; there are still plans to flesh out the rest of the interface so this is properly possible, right?

[fafhrd91]

yes. i'm planing to commit api changes within next couple days.

[tianon]

Excellent, thanks for confirming ❤️

[fafhrd91]

i've just commited new changes @ce21cba8869b8b80849850c1d645fe029dc054b2

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.