allow passing in an aiohttp ClientSession to allow host code to manage pooling etc. about aiobotocore

[jettify]

We configure timeouts and headers very carefully in order to maintain proper request signature, external session object may breaks things...

[thehesiod]

IMHO this would not bode well with how botocore works, botocore has several Config options to handle pool size, etc per client, not per session. See:

• max_pool_connections: https://github.com/boto/botocore/blob/develop/botocore/config.py#L52
• read_timeout: https://github.com/boto/botocore/blob/develop/botocore/config.py#L41
• connect_timeout: https://github.com/boto/botocore/blob/develop/botocore/config.py#L36
• SSL verify: https://github.com/boto/botocore/blob/develop/botocore/client.py#L58

we already use these to configure aiohttp, having users able to specify an aiohttp instance would break this contract.

we allow for setting aiohttp TCPConnector params via AioConfig see: https://github.com/aio-libs/aiobotocore/blob/master/aiobotocore/config.py#L37

[thehesiod]

do you still feel strongly about this? If not let's close this.

[graingert]

I'd still rather be able to pass in a whole aiohttp ClientSession.

[thehesiod]

what is your response to my first comment? @jettify what do you think?

[graingert]

when passing the actual session you could raise an exception if any of the other config variables were non None.

[thehesiod]

there are defaults for all those even if you don't specify them

[thehesiod]

also as botocore doesn't allow you to do this, why should aiobotocore

[graingert]

@thehesiod I'd like botocore to do it too, but I don't use it.

[jettify]

Closing issue for now, looks like we are not going to implement this.