can we remove tini? about aiidalab-docker-stack

[ltalirz]

All one apparently needs to do is to pass the --init flag to docker run.

In our case, the container is started by the dockerspawner, and I guess the configuration option will be something like

c.DockerSpawner.extra_run_kwargs = {
    'init': '',
}

and needs to be added here:
https://github.com/materialscloud-org/openstack-ansible/blob/738b83e2f8295e944f24f2e62079c41fc88aa04d/roles/mc_jupyter/templates/jupyterhub_config.py#L19-L25

See https://github.com/jupyterhub/dockerspawner/blob/19e26f3d1f5fd196b2a750f9e9c525bcfa0c95fb/dockerspawner/dockerspawner.py#L480-L487
and
jupyterhub/jupyterhub#1599

[ltalirz]

Done in 69ccdb5
Still need to check whether this actually works... (@oschuett how do we know?)

[oschuett]

I believe the main purpose of tini was to clean up child processes. So, I would just check if any processes remain after a container was forcefully shutdown.

[ltalirz]

Thanks, Ole!

Note to self: The extra_run_kwargs didn't do the trick yet...

  PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND
    1 scienti+  20   0   19948   3588   3260 S   0.0  0.0   0:00.03 start-sing+

process with PID 1 should beinit (as verified by running the docker image with --init locally)

[ltalirz]

it's extra_start_kwargs, but even this doesn't work because docker-py does no longer support it...

No solution so far: jupyterhub/dockerspawner#192

[ltalirz]

Turns out the solution is

c.DockerSpawner.extra_host_config.update({ 'init': True })

  PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND
    1 scienti+  20   0    1144      4      0 S   0.0  0.0   0:00.04 init