Picky Dropdown retains the filtered list when re-opened. about react-picky

[Aidurber]

Hi @karankumar89
Interesting bug, I'll take a look.
It might be worth exposing the filter as an onFilterChange prop. Ideally as an uncontrolled component it should keep the state on close. There is no way currently to access the filter state.

1. I'll fix the issue with the filter losing state
2. I'll think about the benefit of the additonal prop.

Thanks for raising it!

[Aidurber]

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Aidurber]

@karankumar89 A new release is building now.
You should be safe to upgrade to v3.0.1, it shouldn't have been a major bump.

[karankumar89]

@Aidurber Thats a quick response. Thanks for fixing it. I'll take the new version. Yea it would be nice to get the additional prop.

[karankumar89]

@Aidurber Hey i updated to the v3.0.1 but looks like the issue is still there, is it supposed to fixed from the library or should i do something from my end by using the onFilterChange prop?

[karankumar89]

[Aidurber]

Hmm I wonder if I messed up the build. I'll investigate later.

[karankumar89]

Sounds Good! I'll wait for the new build 😎 BTW I'm really liking the picky, its super smooth and can sustain large data.

[Aidurber]

🎉 This issue has been resolved in version 3.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Aidurber]

Thanks @karankumar89
There's plenty to be improved, for large lists I'd recommend using:
https://github.com/clauderic/react-tiny-virtual-list
or the larger but with more flexibility:
https://github.com/bvaughn/react-virtualized

With > 500 items you will notice a lag, less so in a production build of React.

Regardless, I appreciate your kind words! :)

You were right, by the way, the issue wasn't resolved (this is why I should have written a test initially 😄). I had to do some moving around of the Filter. It was getting unmounted when the dropdown closed so my fix to make the Filter a controlled component internally was fruitless.

I tried to move the filterChange to the Picky component but the performance hit was huge on fairly large lists since the whole tree got re-rendered.

What I've done is a hack but it works.

[karankumar89]

@Aidurber Thanks for the release. I implemented it and it works fine. Also thanks for the suggestions I wil look into them for larger item scenarios

[Riteshgiri]

This does not work for me.
Is there something I need to change to clear filter field when re-opened?

[Riteshgiri]

The content in filter is retained when I click outside and then return back to the filter