Comments (5)
Hi Andre,
Not currently, this is due to react-tiny-virtual-list. Item heights are required to correctly calculate when an item should render.
There is a discussion in #26 about swapping out react-tiny-virtual-list for react-virtualized. It's offers a wide range of different options such as an autosizer and a cellsizer. I'm going to take a look either tonight or tomorrow night at swapping it out to provide a more dynamic virtual list.
Failing finding a nice solution with a nice API, for our needs. Is to remove the internal usage of virtualised lists and leave that up to the developer with a render prop.
Thanks for the issue and the kind words 😃
from react-picky.
After swapping out react-tiny-virtual-list for react-virtualized using the CellMeasurer and AutoSizer components. Dynamic heights with the render prop are possible.
I'll be fixing #26 too before it goes out though.
Here is an example (no more cutting off!):
from react-picky.
That's awesome, that's really what i need.
I Was going to fork this because i need some more customization, but maybe you have interest in doing this.
Right now, you set the string "x selected" statically. I think you should let people decide what to concat when X elements are selected. For example, right now there is no way to change the string values to my native language. I think a simple prop would resolve this, and this would be more customizable for everyone. Just food for thought :p.
Maybe even pass a object with all the strings you can change, with your values as defaults.
from react-picky.
Yeah I can make a prop for that, no problem. See #29
from react-picky.
I think there are only 2 hard coded strings:
- placeholder - which has a prop.
- x selected - which will have a prop.
Do you think the prop would suffice? @AndreBastos23
from react-picky.
Related Issues (20)
- Can we do groupBy feature using react-picky? HOT 2
- How to implement lazy load and windowing with react-picky? HOT 1
- Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined HOT 10
- Picky Dropdown retains the filtered list when re-opened. HOT 2
- class `picky_placeholder` is not set
- Creatable picky HOT 1
- Check "Select All" By Default in Picky HOT 2
- Is it possible to style content in the placeholder area HOT 1
- filter search box should trim spaces before and after content HOT 1
- Unable to load picky.css HOT 1
- class `picky_placeholder` is reversed from version 4.x HOT 1
- Picky 6 HOT 2
- RenderList can have it's own isSelected function based on allSelected state HOT 1
- Would like to have a singleSelectedPlaceholder HOT 2
- Picky is focused twice when navigating using tab button. HOT 1
- maxLength on filter input HOT 3
- Is it possible to close the dropdown after selection if using a single select HOT 2
- [Feature Request]: Sort the selected option to top
- IE11 isn't working in latest version of Picky HOT 2
- Problem with counter of chosen items
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-picky.