dropdownHeight should set max-height instead of height about react-picky

[Aidurber]

Hi @rheinheimer, thanks for the issues.

Height isn't actually set to the dropdown menu, it's set to the VirtualList from react-tiny-virtual-list which creates the height.

I can see the issue.

The only alternative I can see is to swap out react-tiny-virtual-list for react-virtualized specifically for AutoSizer

I'll take a look.
P.S. Thank you for the kind words and thanks for the issues!

[drheinheimer]

Another option could be to pass on this need to react-tiny-virtual-list, but react-virtualized looks pretty solid.

[Aidurber]

Another option would be to remove virtual lists completely. The developer can use a render prop with a virtual list if they needed a performance gain with a particularly large list.

I'll give react-virtualized a look to see if I can get it to play nice. But removing them isn't off the table.

[Aidurber]

@rheinheimer After playing around with react-virtualized, it's not possible to dynamically size the virtual list height based on children.

You can however use a container height. AutoResizer from RV can pass a height prop which is taken from the DOM container the component is positioned in. I don't believe it fill pleasantly fix the issue you're describing.

I could however add a prop that the developer can set to false to disable the virtual list:

• virtual - Boolean (default: true) - Disables virtual list.

Which would leave you with an "organic" list with a more flexible height.

[Aidurber]

@rheinheimer if you pass virtual={false} you won't get a virtual list but the plain list will use min-height for dropdown height.

[drheinheimer]

@Aidurber nice, perfect!