Comments (6)
Thanks for reporting this. We will try to have a look as soon as possible, but it will potentially take until after next week since many of us will be at CHEP.
from podio.
@lkosarz @c-dilks Can you add a more reproducible example, maybe connected with a fake PR that modifies tests/read-multiple.cpp
to use ROOTFrameReader
, if that reproduces the issue?
from podio.
I added a test example with the modified version of podio tests. This crashes even with a simple data type.
Just run:
make
./write
./read
testROOTFrameReader.zip
from podio.
Thanks for providing a reproducer. We will have a look ASAP.
from podio.
I just had a look and this is
- a problem in the API usage of the
ROOTFrameReader
(which is entirely undocumented, so also technically a bug) - and a genuine bug that needs fixing
API usage issue
In the reproducer you have
auto reader = podio::ROOTFrameReader{};
reader.openFile("example_frame1.root");
reader.openFile("example_frame2.root");
reader.openFile("example_frame3.root");
Instead the correct usage would be to use the openFiles
method for this use case and simply pass in the list of files that should be read in one go:
auto reader = podio::ROOTFrameReader{};
reader.openFiles({"example_frame1.root", "example_frame2.root", "example_frame3.root"});
(or pass a std::vector<std::string>
instead of building it on the fly)
Internal bug
There is an additional bug inside ROOTFrameReader::readEventMetaData
that is only triggered with multiple files, but that is in the end easy to fix by properly handling the switching of files in the TChain
.
from podio.
Thank you! My initial test was with openFiles() and passing of a pre-defined vector, so not on the fly. I did see the same crash happening in both openFiles() and multiple openFile() cases. I did also see memory leaks, but haven't checked it for this standalone code, I sent you. Maybe we should double-check for these too.
from podio.
Related Issues (20)
- discussion: Possibility of differing in-memory and on-file datatypes HOT 1
- Add tests for JSON output
- Trivial return types of generated get methods should be by value instead of const reference
- Switch to black for formatting python sources HOT 1
- how to retrieve the cell ID encoding from the metadata in the output ROOT file HOT 2
- RNTuple interface changed in ROOT HOT 1
- collection push_back and value_type incompatible with some std iterator adaptors HOT 1
- Inconsistent reference access for Mutable types
- Schema evolution script does not flag some evolutions as impossible
- Frame serialization/deserialization HOT 12
- Automatically ship collection level metadata
- GenericParameters should not return a default constructed / empty value if key is not present HOT 4
- Warnings when generating ROOT dictionaries HOT 1
- GenericParameters should be stored the same way for TTree and RNTuple backends HOT 6
- Leak in SIO Frame reading
- Document the cmake functionality HOT 4
- Use types of heterogeneous origins in interfaces HOT 3
- Document more advanced cmake usage
- Make it possible to store more version information of generated EDMs
- OneToOne relations are not preserved on `clone()` since v01-00 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from podio.