Coder Social home page Coder Social logo

Comments (1)

tmadlener avatar tmadlener commented on July 23, 2024

This could also be fixed by making the check for discovering clang-format more robust. Currently, it just checks for the presence, but does not try to actually run something:

def get_clang_format():
"""Check if clang format is available and if so get the list of arguments to
invoke it via subprocess.Popen"""
try:
cformat_exe = subprocess.check_output(['which', 'clang-format']).strip()
return [cformat_exe, "-style=file", "-fallback-style=llvm"]
except subprocess.CalledProcessError:
print("ERROR: Cannot find clang-format executable")
print(" Please make sure it is in the PATH.")
return []

Actually trying to run clang-format with all the flags we run it later should already fix all issues, because in case that does not succeed the generation will simply not format generated code.

We actually do something like that in the cmake macros:

execute_process(COMMAND ${CLANG_FORMAT_EXE} --fallback-style OUTPUT_VARIABLE CLANG_FALLBACK_STYLE ERROR_VARIABLE CLANG_FALLBACK_STYLE_ERR)

Overall, even that doesn't cover all possibilities yet, because the contents of .clang-format are in principle LLVM version dependent, and we require probably at least 9 or 10.

from podio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.