Discussion about python code generator update / refactoring about podio

[joequant]

One idea that I'd like to throw out is whether it would be a good idea to include templated classes so instead of merely having

class ExampleHitObj {
}

you also have

template<>
class Obj<ExampleHit> {
 }
 
typedef ExampleHitObj Obj<ExampleHit>

My suspicion is that if the classes were templatized that some of the code duplication could be removed
and you could write generic functions for specificing the reltationship between Obj and Data, and you
can do things like write generic functions to move between const and non-const objects and convert to and
from STL and other frameworks.

Thoughts?

[tmadlener]

That could potentially make the code generation a bit easier to do. Also the Obj classes are not really user facing, since they just handle the relations under the hood, but the interaction with them is all done through the actual class. So I think in principle nothing speaks against trying to have a template solution. However, again the relations between the different objects might be a problem, because they can differ greatly between different objects and that requires different members to be present in the class. I don't think that is possible with a template class, but maybe with newer c++ standards it is?

Have you tried to implement the Obj as a template class that can be reused by simply instantiating it differently?

[joequant]

Still trying to get used to the code (and still spending a crazy amount of time filling out bureaucratic forms), but I can do a quick experiment to try to templatize things to see if anything breaks.

…

On Mon, Jul 13, 2020 at 4:27 PM Thomas Madlener ***@***.***> wrote: That could potentially make the code generation a bit easier to do. Also the Obj classes are not really user facing, since they just handle the relations under the hood, but the interaction with them is all done through the actual class. So I think in principle nothing speaks against trying to have a template solution. However, again the relations between the different objects might be a problem, because they can differ greatly between different objects and that requires different members to be present in the class. I don't think that is possible with a template class, but maybe with newer c++ standards it is? Have you tried to implement the Obj as a template class that can be reused by simply instantiating it differently? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWGAGMDKWSMWP6PM4NS3WTR3LAQFANCNFSM4OVY6WCA> .

[tmadlener]

Since #117 and #120 have been merged I will close this as the main questions have been addressed there.