Coder Social home page Coder Social logo

Comments (6)

sdgathman avatar sdgathman commented on June 24, 2024

Passes on golang-1.18

from go-linq.

ahmetb avatar ahmetb commented on June 24, 2024

Interesting. If you wanna debug, I'm open to patches.

from go-linq.

neilalexander avatar neilalexander commented on June 24, 2024

Probably related to the change in sorting algorithm to pattern-defeating quicksort in Go 1.19.

https://tip.golang.org/doc/go1.19#sort

from go-linq.

sdgathman avatar sdgathman commented on June 24, 2024

I'm not a go programmer, but you'd think there would be a sort_unstable() to get the faster algorithm rather than breaking a bunch of things that depend on stability.

from go-linq.

sdgathman avatar sdgathman commented on June 24, 2024

Since this package seems to be about linking to case insensitive libraries, the result might be actually valid. But the verbatim check is too strict for an unstable sort. How about running the output through an undependent stable sort (e.g. unix sort program with case insensitive option) and check that the result is unchanged? Would that be valid?

from go-linq.

neilalexander avatar neilalexander commented on June 24, 2024

I'm not a go programmer, but you'd think there would be a sort_unstable() to get the faster algorithm rather than breaking a bunch of things that depend on stability.

There is probably already some difference between sort.Sort and sort.Stable.

from go-linq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.