Comments (6)
I strongly agree with you, this wasn't my patch, missed this out. Replaced console.error
with callbacks but saved if
cases for debugging purposes ce1e4eb
from onvif.
Same problem here. Instead of printing the error to console in some cases, the script should call the callback function for every case, right? Might be useful for debugging but it isn't in production mode. :-(
Cam.js: lines 185 - 193
/* address, port number or IPCam error */
if (err.code === 'ECONNREFUSED' && err.errno === 'ECONNREFUSED' && err.syscall === 'connect') {
console.error(err);
/* network error */
} else if (err.code === 'ECONNRESET' && err.errno === 'ECONNRESET' && err.syscall === 'read') {
console.error(err);
} else {
callback(err);
}
from onvif.
thank you ;-)
from onvif.
ah, sorry for that.
I asked @sunnyworm to send PR if he fixed the connection refuse bug with a broken firmware on one of our IPcam, but I forgot to do code review...
https://github.com/agsh/onvif/blame/fbf1cf9a7e165a440d9193f6804669d815f822f4/lib/cam.js#L186
Will mention this to him and prevent any further bug like this.
Thanks @agsh for fixing!
from onvif.
Ran into this today as well, thanks for fixing.
Can we get this released on npm?
from onvif.
Done! 0.4.3
from onvif.
Related Issues (20)
- Non conform /onvif/media2_service response leads to Error: Unrecognized configuration HOT 2
- setOSD(): position can take effect, but plaintext does not HOT 1
- Question: I have a dvr/nvr dahua so the discover method retrieve me 1 record. Is there any other method that can tell me how many cameras the dvr has? HOT 2
- Error: GetRecordings
- Compatibility of Axis M5000-G PTZ Camera. HOT 4
- HikVision "Wrong ONVIF Soap Response" Error HOT 17
- Find recording from nvr within specific time HOT 4
- ONVIF SOAP Fault during connect with Vivotek camera's HOT 3
- Action string in Content-Type causes failures with Illustra cameras
- Discovery has been unable to search, how to debug it
- Discovery displays HTTP servers on local network
- Wrong ONVIF SOAP Response on AXIS Cameras
- NetworkInterfaceSetConfiguration documentation change
- feat req: custom position in createOSD HOT 1
- No events for TAPO C520 C510 HOT 1
- relativeMove documentation incorrect
- Unsubscribe: Triggers a second unsubscribe via _eventRequest
- getRecordingOptions not working with UNIVIEW Channels | brand issue | ONVIF SOAP Fault: Optional Action Not Implemented
- Add an option to set pull-request timeout
- getStreamUri not working correctly on multi channel NVR HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onvif.