tables creation with more than 255 arguments about sqlacodegen

[agronholm]

Original comment by Alex Grönholm (Bitbucket: agronholm, GitHub: agronholm):

---

You could just wrap the column list in *[...].

[agronholm]

Original comment by tomanizer (Bitbucket: tomanizer, GitHub: tomanizer):

---

+1 for wrapping more than 255 columns in *[...]

[agronholm]

Original comment by Tom D (Bitbucket: tom-d, GitHub: tom-d):

---

Thank you for the heads up. It's not ideal, but very useful. In the meantime I'll fork/tag a release for myself.

[agronholm]

Original comment by Alex Grönholm (Bitbucket: agronholm, GitHub: agronholm):

---

I have uncommitted changes that change the code layout radically. So prepare for breakage when 2.0 final is released.

[agronholm]

Original comment by Tom D (Bitbucket: tom-d, GitHub: tom-d):

---

+1
I get this too.
In my use case I run CodeGenerator directory so I could subclass to patch the rendering but had to pip install directly from master, all of which is very brittle.

[agronholm]

Original comment by Alex Grönholm (Bitbucket: agronholm, GitHub: agronholm):

---

I will keep this issue open to remind me to do that automatically for tables with 256 or more arguments.

[agronholm]

Original comment by Cristian Mitroi (Bitbucket: cristianxyz, GitHub: Unknown):

---

I guess I could, but it turns out there are multiple such tables. Wouldn't just changing the code to do so from the get-go be better for future cases?

[agronholm]

Original comment by Cristian Mitroi (Bitbucket: cristianxyz, GitHub: Unknown):

---

From sqla docs, I could tell that you could iterate through the list of columns, and add them one at a time. Would this work? http://docs.sqlalchemy.org/en/rel_1_0/core/metadata.html#sqlalchemy.schema.Table.append_column

Would this be the line where the change could be made? https://bitbucket.org/agronholm/sqlacodegen/src/8be7df77c4f70036e85c6c02618b6538d4431fbc/sqlacodegen/codegen.py?at=master&fileviewer=file-view-default#codegen.py-515

[agronholm]

Original comment by Cristian Mitroi (Bitbucket: cristianxyz, GitHub: Unknown):

---

#!

  File "new.py", line 7
    t_ACINVOICE = Table('ACINVOICE', metadata,
SyntaxError: more than 255 arguments

gist: https://gist.github.com/cristianmtr/96c9a851bee141855da1

[agronholm]

Original comment by Alex Grönholm (Bitbucket: agronholm, GitHub: agronholm):

---

Syntax error? I just tried passing 300 arguments to a function and it worked fine.

[agronholm]

Since this restriction has been lifted in Python 3.7, I'm closing the issue.