KeyError: 'SerializableManager' on db migrations in Django 1.10+ (1.11) about django-serializable-model

[dev0088]

Thanks.
Hope I'll be able to use this package, as soon as possible. :)

[dev0088]

I gonna try it tomorrow. I worked too much, today. So I'm already a squeezed orange.
I'll try it, agin, tomorrow. And I'll let you know the result.
Thanks for your help!

[agilgur5]

This particular issue should be fixed in v0.0.5-alpha.1. Might need to specify the version when re-installing as it's a pre-release.

dat turnaround time tho 😆 . happened to be at my computer working on another library anyway haha. thanks for sticking through the churn and pointing out issues @ninjadev999 ! :)

[agilgur5]

Ah yep that's a compatibility bug.
This is a Django 1.10+ ism since it added the base_manager_name field. I've never used Django 1.10+ (one of the reasons it's listed as "likely works"), and just followed the docs on it but the docs have no example usage 😅 .

Apparently the correct "name" in this case is supposed to be 'objects', not 'SerializableManager'.
Apparently you're supposed to use the string version of the name of the attribute that is set to the instance and I didn't know that, sorry.

I'll have to add a PR to the Django docs to improve this as this could be a lot clearer with an example.

[agilgur5]

Yea I'll throw up an alpha release in a bit.

Alpha because maybe there's some other issues in 1.10+ I don't know 😕 . If only adding tests to this weren't quite so difficult/tedious (lots of fixtures/setup, including multiple Django versions set-up too).

[dev0088]

Make sense. :)

[agilgur5]

I think you could probably workaround this if you wanted to by setting the base_manager_name yourself:

class YourModel(SerializableModel):
     ...

    class Meta:
        base_manager_name = 'objects'

potentially might need to set objects = SerializableManager() directly, but shouldn't need to since it's inherited.

[agilgur5]

Hey @ninjadev999 , were you able to try out v0.0.5-alpha.1? Did you run into any other issues/have any other feedback? Will publish v0.0.5 if all good

[agilgur5]

Ok, I didn't hear back from you @ninjadev999 , so I've released v0.0.5 that includes the alpha changes and a typo fix for editable fields.

[dev0088]

@agilgur5 , I was very busy. I'll check the release version v0.0.5 within 2 days and I'll let you know.
Thank you!

[agilgur5]

As of #6 and v0.0.6, I've now added tests with 92% code coverage and a matrix that confirms compatibility for Django 2.2, 1.11, 1.9, and 1.5 as well as Python 3.5, 3.4, and 2.7.
So these types of issues should mostly be in the past now 🙂

Also noting that the fix for this in 8c0d571 broke <1.10, which the new test matrix discovered, and this was later fixed in 803155b so that it works for both <1.10 and 1.10+