Coder Social home page Coder Social logo

Don't fail on push to master about commitsar HOT 5 CLOSED

aevea avatar aevea commented on May 26, 2024
Don't fail on push to master

from commitsar.

Comments (5)

aexvir avatar aexvir commented on May 26, 2024 2

I don't think that linting all the commits to the last tag makes, even if capping it makes much sense.

I can't seem to find numbers, but I'd say that a pretty big amount of PRs usually include a single commit, so, for me, the second option makes more sense. It will end up checking the same, non-related commits many times. And it also can cause issues on projects that didn't follow the convention and just recently they added this step. Also, not a big fan of having an arbitrary number of commits checked, but that might be just me.

Linting just the last commit when there is nothing to compare against, and showing a warning would be the way to go in my opinion.

from commitsar.

fallion avatar fallion commented on May 26, 2024

@matoous what would be the expected behaviour here? Because CI will see the last commits as equal. Check last 5 commits?

from commitsar.

fallion avatar fallion commented on May 26, 2024

Offending line https://github.com/commitsar-app/commitsar/blob/7cda1dab9463b9d408ca1b7d3a22a1da6e3e844f/cmd/root_runner.go#L61

from commitsar.

matoous avatar matoous commented on May 26, 2024

I see a few options here:

  1. Lint all commits to last tag.
  2. Lint only last commit.
  3. Lint X last commits.

I think that combination of 1 and 3 would be best (lint all commits until last tag but cap to 10 commits max maybe?). Either way, printing a warning should be enough to inform the user that this is not the intended use-case and that the behavior might differ from running on separate non-master branch.

from commitsar.

fallion avatar fallion commented on May 26, 2024

Closed by #145 and #146

from commitsar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.