Comments (5)
I don't think that linting all the commits to the last tag makes, even if capping it makes much sense.
I can't seem to find numbers, but I'd say that a pretty big amount of PRs usually include a single commit, so, for me, the second option makes more sense. It will end up checking the same, non-related commits many times. And it also can cause issues on projects that didn't follow the convention and just recently they added this step. Also, not a big fan of having an arbitrary number of commits checked, but that might be just me.
Linting just the last commit when there is nothing to compare against, and showing a warning would be the way to go in my opinion.
from commitsar.
@matoous what would be the expected behaviour here? Because CI will see the last commits as equal. Check last 5 commits?
from commitsar.
Offending line https://github.com/commitsar-app/commitsar/blob/7cda1dab9463b9d408ca1b7d3a22a1da6e3e844f/cmd/root_runner.go#L61
from commitsar.
I see a few options here:
- Lint all commits to last tag.
- Lint only last commit.
- Lint X last commits.
I think that combination of 1 and 3 would be best (lint all commits until last tag but cap to 10 commits max maybe?). Either way, printing a warning should be enough to inform the user that this is not the intended use-case and that the behavior might differ from running on separate non-master branch.
from commitsar.
from commitsar.
Related Issues (20)
- Action Required: Fix Renovate Configuration
- Commitsar fails with 0 commits to check on main branch HOT 3
- Migrate docs to something other than Docusaurus
- `--all` flag broken in CI? HOT 9
- commitsar.tech broken
- Feature Request - Compatible with Bottlerocket (containerd) HOT 3
- Dependency Dashboard
- commitsar fails on shallow clone HOT 1
- Simplify project
- Make revert commit generated by git CLI compliant
- Windows executable HOT 1
- Conventional revert commits are ignored
- Possibility to check remote branch HOT 1
- commitsar not working on main branch as ref HOT 2
- commitsar and brown field on multiple branches structure HOT 3
- commitsar failing on "squash! " commit messages
- Pull request pipeline failing with "no linked PullRequests found" in GitHub Actions HOT 1
- Pull request pipeline not working on GitHub Enterprise Server due to default GitHub API URL HOT 2
- Configure GitHub action HOT 1
- Respect conventional-commits grammar for scope
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commitsar.