Comments (3)
Thanks @thib3113 for opening the issue.
Let me have a look at it.
I will contact you soon.
from unifi-udm-backup.
Hi @aessing , In fact, I just saw my first link is too specific ( link to a commit, and not the branch ) .
I've done another commit just after commeting, because I forgot to take some changes from local .
About the ${CRON_SCHEDULE} , in fact I add it on line where I echo the cron to cron file .
So, with that, I totally separe vars, and code . And we can say "stop to edit after line XXX" .
But, it's as you prefer .
I'm preparing the PR
from unifi-udm-backup.
Hi @thib3113,
Thanks for your contribution.
Please open a PR for your change. I will merge them into the repo.
I found a few small things in your code I would like to ask you to change before merging:
- You forgot the CRON_SCHEDULE in line 50. It should look like:
CRON_CMD="${CRON_SCHEDULE} ${CRON_CMD} ${BACKUP_IMG}"
- Could you please remove the comment hash on line 54 and enable writing to the cronfile. So remove line 54 and line 53 should look like:
echo "${CRON_CMD}" > ${CRON_FILE}
Also could you please remove the comment hash from line 35, as the standard schould be backup up both services. Perhaps you can add a comment, how to disable backup for Protect.
Thanks
Andre
from unifi-udm-backup.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unifi-udm-backup.