No deep copy of `as_config_s` in `aerospike_init` after making `hosts` member as a pointer instead of C-array in commit 6b5a82f8 about aerospike-client-c

[djc]

Ping! This seems like an obvious bug in the client C libraries, please review the material.

[BrianNichols]

We will fix this bug in the next release.

[djc]

@BrianNichols that's good to hear. Do you have an approximate ETA for this?

[BrianNichols]

The C client is released approximately once per month, so it should be released by the end of this month.

In the meantime, don't call as_config_destroy() because as_cluster_create() transfers ownership of hosts and cluster_id to as_cluster. The client will not leak memory if as_cluster_create() is successful.

[BrianNichols]

This problem will be fixed by making as_config_destroy() a private function. First, all dynamically allocated as_config variables will be copied using setter functions. When aerospike_init() is called, the client will assume ownership of all config fields. When aerospike_destroy() is called, as_config_destroy() will be internally called.

The user should not call as_config_destroy() directly.

[eldar-activevideo]

Thank you for update!

I suggest to make transferring of ownership in aerospike_init more explicit for user because currently it's not obvious that aerospike_init takes ownership of as_config object.

[BrianNichols]

C client 4.1.1 has been released.

http://www.aerospike.com/download/client/c/4.1.1/