Coder Social home page Coder Social logo

Comments (5)

BrianNichols avatar BrianNichols commented on June 11, 2024

aerospike-client-c does not allow direct branching. You will need to fork the repository and then make a pull request (Click "Fork" icon in upper right hand corner on aerospike-client-c github page).

Note that "aerospike/ck" is just a copy of the concurrencykit repository include files with some minor changes.

ConcurrencyKit

I suggest submitting a pull request to the ConcurrencyKit too. That way, both repos can stay in sync.

from aerospike-client-c.

BrianNichols avatar BrianNichols commented on June 11, 2024

Also, which version of aerospike-client-c are you using? The assembly code in cf_atomic.h was replaced with ConcurrenyKit methods over 6 months ago. See:

https://github.com/aerospike/aerospike-common/blob/bc285243acc5333fc4abd85f47c66e85cfff2f03/src/include/citrusleaf/cf_atomic.h

I think the Aerospike code in PerfKitBenchmarker is out-of-date.

from aerospike-client-c.

mlpesant avatar mlpesant commented on June 11, 2024

@BrianNichols, thanks for your response. It took me a little while to get this figured out, but I committed a change to aerospike-client-c/Makefile yesterday and then pushed it with the command
git push origin ppc64
I then tried to do a pull request, but it says there's nothing to compare. Will my change make it in or is there something else I need to do? Thanks a lot for your help. I'm still learning how to work with git and the open source community.

from aerospike-client-c.

BrianNichols avatar BrianNichols commented on June 11, 2024

The pull requests were all received. The aerospike-client-c and aerospike-mod-lua pull requests had the correct Makefile change. The aerospike-common pull request had lots of changes that clearly was crafted from a very old version. I modified aerospike-common to only include the Makefile change.

from aerospike-client-c.

BrianNichols avatar BrianNichols commented on June 11, 2024

C client 4.0.4 has been released.

from aerospike-client-c.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.