Comments (5)
aerospike-client-c does not allow direct branching. You will need to fork the repository and then make a pull request (Click "Fork" icon in upper right hand corner on aerospike-client-c github page).
Note that "aerospike/ck" is just a copy of the concurrencykit repository include files with some minor changes.
I suggest submitting a pull request to the ConcurrencyKit too. That way, both repos can stay in sync.
from aerospike-client-c.
Also, which version of aerospike-client-c are you using? The assembly code in cf_atomic.h was replaced with ConcurrenyKit methods over 6 months ago. See:
I think the Aerospike code in PerfKitBenchmarker is out-of-date.
from aerospike-client-c.
@BrianNichols, thanks for your response. It took me a little while to get this figured out, but I committed a change to aerospike-client-c/Makefile yesterday and then pushed it with the command
git push origin ppc64
I then tried to do a pull request, but it says there's nothing to compare. Will my change make it in or is there something else I need to do? Thanks a lot for your help. I'm still learning how to work with git and the open source community.
from aerospike-client-c.
The pull requests were all received. The aerospike-client-c and aerospike-mod-lua pull requests had the correct Makefile change. The aerospike-common pull request had lots of changes that clearly was crafted from a very old version. I modified aerospike-common to only include the Makefile change.
from aerospike-client-c.
C client 4.0.4 has been released.
from aerospike-client-c.
Related Issues (20)
- warning: 'MSG_NOSIGNAL' macro redefined (on macOS) HOT 1
- Deleting bins by setting values to null or empty string HOT 1
- Undefined symbols in static library HOT 2
- cmake support HOT 4
- Is this project still under maintenance HOT 1
- Unable to found benchmarks in aerospike-client-c HOT 2
- Logstash Pipeline Error
- Crash in as_node_ensure_login_shm when remote servers are restarted HOT 16
- Compile failed with "the clang compiler does not support '-march=nocona'" HOT 2
- crash inside as_cluster_tend on arm64 HOT 4
- Give a name to worker threads HOT 3
- apple silicon / arm support HOT 9
- Release tagged 4.6.24 refers to missing .gitmodules HOT 1
- On batch reads only AS_POLICY_REPLICA_SEQUENCE will actually find new nodes for requests, AS_POLICY_REPLICA_ANY will try the same node and fail again. HOT 6
- aerospike-client-c link error with extra compiler flags -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer HOT 1
- can not build without lua HOT 1
- Missing as_buffer.h in installed includes HOT 1
- scan callback failing with memory fault issue HOT 1
- Build fails for 6.4.1 with luajit HOT 1
- crash on exit in as_cluster_tender (after libuv event loop is stopped) HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aerospike-client-c.