Coder Social home page Coder Social logo

Comments (7)

seancorfield avatar seancorfield commented on July 19, 2024 1

No, I ran some tests with this patch in place and the total time was about 49s without the patch (and using filters) and 45s with the patch (and using include). The pod stuff is a huge time sink, but it's a fairly static overhead -- and for those of us who need the isolation of pods to run tests with different sets of dependencies :)

Mostly the issue is that for any given set of tests I want to run, I don't want all my namespaces loaded -- I just want the subset loaded that my selected tests will load.

from boot-test.

seancorfield avatar seancorfield commented on July 19, 2024 1

This can be closed now as PR #30 provides this and was just merged in (thank you!).

from boot-test.

arichiardi avatar arichiardi commented on July 19, 2024

I started working on this one a bit, but at the moment the :namespaces option is necessary for the test task: it is an --include already. So I was thinking of proposing the alternative that I implemented in boot.test (core).

If :namespaces is not there, we include all the tests on the classpath and by doing this now we can have --include and --exclude (or --invert) set of regexes to be on par with the other boot tasks.

How does it sound?

from boot-test.

crisptrutski avatar crisptrutski commented on July 19, 2024

Sounds good to me! We should probably ping an adzerker though :)

from boot-test.

daveyarwood avatar daveyarwood commented on July 19, 2024

Sorry I'm late to the party. @arichiardi 's idea sounds good to me, let's do it!

from boot-test.

seancorfield avatar seancorfield commented on July 19, 2024

Note that boot-expectations uses include / exclude as regexes to filter namespaces before even trying to require them. boot-test today requires all namespaces unless you specify a complete set of namespaces to load.

The problem with filters is that it filters the Vars after requiring all the namespaces.

I'd be happy to send a PR for -I / --include / -X / --exclude to match boot-expectations as regexes to filter the names of namespaces prior to requiring them.

from boot-test.

arichiardi avatar arichiardi commented on July 19, 2024

Probably the above is also the reason why tests are kind of slow, I would love to see a patch then.

from boot-test.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.