Comments (4)
I think if you want to offer support for old versions, it is ok to do it, consider that these users if they don't update the PHP then they don't update your library either.
I think the best solution would be to make a dedicated branch for legacy PHP and a new one for supported PHP, where you can have well-tested and more secure code.
It would be nice for those who are using PHP not abandoned to have an updated code, especially for a library that deals with payments.
from adyen-php-api-library.
Hey,
As the one behind making this decision, let me open my thought process.
Indeed we offer support for PHP versions that are very outdated. The reason being that it's quite difficult for us to track which PHP Versions are being used by merchants.
It's also pretty hard to setup a PHP environment with said versions. Ondrej's PPA for PHP versions only offer versions 5.6+, and finding boxes that support PHP 5.3 is not so trivial.
And then there's PHPUnit support, which I believe support for PHP 5.3 was dropped in PHPUnit 5. This means that it's hard to find documentation for PHPUnit when we want to create or change tests that require a bit more than just assertEquals
.
We discussed internally and decided to maintain PHP 5.3 as a sanity-only check. Travis CI offers a PHP 5.3 box, so we run the built-in PHP Lint (php -l
) and make sure that the code compiles. Meanwhile, in PHP 7.4 we run Unit Tests in Travis and make try to make sure it works.
Thank you for raising this issue. We are studying ways to figure this out as well, while still maintaining a healthy relationship with our customers.
I'll close this issue soon since it's something we're actively trying to improve, even though the issue itself isn't solved yet. Feel free to leave comments or open more issues to discuss this kind of improvements.
Cheers!
Marcos
Adyen
from adyen-php-api-library.
Hey @rvitaliy,
Sorry for the late response and thank you for this feedback, we'll take a look at this support discrepancy and keep you posted.
รngel Campos
from adyen-php-api-library.
That is a great idea, one that probably didn't pop in our heads. I am sharing this with the team and we will discuss if there's a way to do this while keeping our sanity.
Cheers!
Marcos
Adyen
from adyen-php-api-library.
Related Issues (20)
- Delete stored payment returns as error HOT 1
- Getting curl timeout on success calls with runTenderSync() on send POS terminal a payment HOT 20
- Please reopen issue #473
- API response not correctly handled HOT 2
- composer require adyen/php-api-library pulling a different version of code than the specified version in the doc HOT 3
- Missing option to get result of the payment session? HOT 2
- CheckoutStateDataValidator does not allow RequestedTestAcquirerResponseCode for testing purposes HOT 2
- CheckoutStateDataValidator removes origin parameter? HOT 4
- Attempted to call an undefined method named "isValidWebhookHMAC" of class "Adyen\Util\HmacSignature"." at Adyen/Service/WebhookReceiver.php line 39 HOT 1
- Fatal error on "Disable stored payment details" API call HOT 1
- Replacement for deprecated RiskManagement service HOT 1
- RecurringApi::deleteTokenForStoredPaymentDetails call fails even though the request is correctly performed and successfully finished HOT 4
- Error using splitCardFundingSources in paymentMethods HOT 3
- Error on PaymentRequest with v16.1.0 HOT 3
- Requesting session API returns failure ( version 17.0.0) HOT 1
- Changes to CreateCheckoutSessionRequest and CreateCheckoutSessionResponse in 17.2.0 break hosted checkout HOT 2
- Checkout Api not up to date HOT 1
- Wrong parameter type in metadata functions HOT 1
- Can you make this library not suck? HOT 1
- Non-nullable billingToken issue for non-recurring PayPal payments HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adyen-php-api-library.