Comments (10)
Jah, this is a change in ember itself. It confused me for a while with a different project I just upgraded to 1.13.2 - not sure if this is a regression or a fix.
The work around for now is to copy the component file to your host application, and import the layout from its location in your host app, then pass that as to the layout attribute on your local component file.
from ember-infinity.
@hhff. Could you provide more detailed instructions for this workaround? I'm not quite sure what you mean.
from ember-infinity.
Run ember g infinity-template
, then create a new file in your host application at app/components/infinity-loader.js
like so:
import layout from '../templates/components/infinity-loader';
import infinityLoader from 'ember-infinity/components/infinity-loader';
export default infinityLoader.extend({
layout: layout
});
Gonna investigate this now!
from ember-infinity.
Thanks, @hhff.
from ember-infinity.
Lets keep this open until I fix this without the above workaround
from ember-infinity.
The basic problem is that when the layout is defined, you have to specifically override the layout. Once the layout definition is gone from the addon template, it will lookup the template in the app, and when the user has a template in their app with the same name, that template will win over the addon's template in the app folder.
from ember-infinity.
so ur saying I have to delete 2 lines of code @trabus
i think i can handle that
from ember-infinity.
oh and move 1 file
still, i can handle it
from ember-infinity.
Or add one file to your blueprint. ;)
from ember-infinity.
thanks @trabus ! just want to maintain the old override process for people updating to new versions. I've also stacked the component with so much good stuff like class name binding that I only want super users to have the component file in their host app.
from ember-infinity.
Related Issues (20)
- infinity-loader needs to unhide on model change HOT 7
- model.canLoadMore not updating HOT 6
- infinityLoader renders JSON response data twice HOT 4
- isVisible is deprecated in 3.15
- 2.1.0 throws an EEXIST: file already exists on app build HOT 8
- Is it possible to use this component with a horizontal list? HOT 6
- Ember Infinity not working with latest Ember Data 3.17.0 & 3.16.0 HOT 9
- Possible issue with ember-source 3.16.2 HOT 6
- Not working in "ember-cli": "~3.4.4"? HOT 2
- Could not find plugin "proposal-class-properties". Ensure there is an entry in ./available-plugins.js for it.
- Demo link goes to 404. HOT 1
- Non-blocking model hook breaks `reachedInfinity`
- Problem with ember-in-viewport HOT 5
- Update doc examples with ES6 Classes
- devDependencies and dependencies are out of date HOT 2
- Issue with loadPrevious and scrollable HOT 2
- Will the project be supported for ember 4? HOT 2
- Error: Could not find module `@ember/polyfills` imported from `ember-in-viewport/initializers/viewport-config`
- Caching unchanged content ExtendedInfinityModel
- Side effects due to transfer ownership
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-infinity.