Coder Social home page Coder Social logo

Comments (10)

hhff avatar hhff commented on September 21, 2024

Jah, this is a change in ember itself. It confused me for a while with a different project I just upgraded to 1.13.2 - not sure if this is a regression or a fix.

The work around for now is to copy the component file to your host application, and import the layout from its location in your host app, then pass that as to the layout attribute on your local component file.

from ember-infinity.

aaronrenner avatar aaronrenner commented on September 21, 2024

@hhff. Could you provide more detailed instructions for this workaround? I'm not quite sure what you mean.

from ember-infinity.

hhff avatar hhff commented on September 21, 2024

Run ember g infinity-template, then create a new file in your host application at app/components/infinity-loader.js like so:

import layout from '../templates/components/infinity-loader';
import infinityLoader from 'ember-infinity/components/infinity-loader';

export default infinityLoader.extend({
  layout: layout
});

Gonna investigate this now!

from ember-infinity.

aaronrenner avatar aaronrenner commented on September 21, 2024

Thanks, @hhff.

from ember-infinity.

hhff avatar hhff commented on September 21, 2024

Lets keep this open until I fix this without the above workaround

from ember-infinity.

trabus avatar trabus commented on September 21, 2024

The basic problem is that when the layout is defined, you have to specifically override the layout. Once the layout definition is gone from the addon template, it will lookup the template in the app, and when the user has a template in their app with the same name, that template will win over the addon's template in the app folder.

from ember-infinity.

hhff avatar hhff commented on September 21, 2024

so ur saying I have to delete 2 lines of code @trabus

i think i can handle that

from ember-infinity.

hhff avatar hhff commented on September 21, 2024

oh and move 1 file

still, i can handle it

from ember-infinity.

trabus avatar trabus commented on September 21, 2024

Or add one file to your blueprint. ;)

from ember-infinity.

hhff avatar hhff commented on September 21, 2024

thanks @trabus ! just want to maintain the old override process for people updating to new versions. I've also stacked the component with so much good stuff like class name binding that I only want super users to have the component file in their host app.

from ember-infinity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.