Got "ParseError: Unexpected token" while using yield about core

[gearsdigital]

Found a workaround using https://github.com/tj/co

  getToken(code) {
    let oauth2Client = this.oauth2Client;
    oauth2Client.getToken(code, function (err, tokens) {
      if (!err) {
        co(function*() {
          oauth2Client.setCredentials(tokens);
          yield Database.from('admin').insert({'access_token': tokens.access_token});
          return tokens.access_token;
        }).then(function (token) {
          console.info(`Token saved to database (${token}).`);
        }, function (err) {
          console.error(err.stack);
        });

      }
    });
  }

[thetutlage]

how are you calling getToken in your controller ?

[gearsdigital]

This is the controller:

'use strict';
const GoogleCalendarService = use('App/Services/GoogleCalendarService');

class CalendarController {

  constructor() {
    this.calendarService = new GoogleCalendarService();
  }

  * authorize(request, response) {
    let params = request.get();
    this.calendarService.getToken(params.code);

    const view = yield response.view('index.html');
    response.ok(view);
  }

  * index(request, response) {
    const view = yield response.view('index.html', {url: this.calendarService.generateAuthenticationUri()});
    response.ok(view);
  }

}

module.exports = CalendarController;

And here the appropriate route:

Route.get('/auth', 'CalendarController.authorize');

[thetutlage]

You will have to use the yield while using getToken since it is a generator method

yield this.calendarService.getToken(params.code);

[gearsdigital]

I tried it already, but it did not work out. In this case i got the parse error:

yield Database.from('admin').insert({'access_token': tokens.access_token}); ^ ParseError: Unexpected token

getToken(code) {
    let oauth2Client = this.oauth2Client;
    oauth2Client.getToken(code, function (err, tokens) {
      if (!err) {
        oauth2Client.setCredentials(tokens);
        yield Database.from('admin').insert({'access_token': tokens.access_token});
      }
    });
}

* authorize(request, response) {
    let params = request.get();
    yield this.calendarService.getToken(params.code);

    const view = yield response.view('index.html');
    response.ok(view);
}

[thetutlage]

Ohh got it, coz you are trying to run it inside the callback of oauth2Client.getToken and generators needs to be at the first level of * method.

I am not a big fan of callbacks and if you are interested you can make use of https://github.com/tj/node-thunkify. It will convert your callbacks to generator friendly methods. Something like this

const oauthToken = thunkify(oauth2Client.getToken)
try {
  const tokens = yield oauthToken(code)
  oauth2Client.setCredentials(tokens);
  console.log(`Save ${tokens.access_token} to database`);
  yield Database.from('admin').insert({'access_token': tokens.access_token});
}
catch (e) {
  console.log(e)
}

[gearsdigital]

I'll try that... :) Thank you for your fast and helpful support bro! 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.